fix: Enable 'High priority' to be selected easily in Auto Suggest #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1943 The order of priorities in auto suggestion is now - high - medium - low - highest - lowest This retains the original order, for people's muscle memory. And it means that the longer names are after the shorter ones, which also makes it possible to type both, and it means that typing parts of names selects the same result as before highest and lowest were added.
claremacrae
added
the
scope: auto-suggest
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Via auto-suggest I keep ending up with tasks of Highest priority accidentally. See #1995 for a write-up.
This PR reverts to the original order of priority items in the auto-suggest menu.
The order of priorities in auto suggestion is now:
Benefits:
Motivation and Context
Fixes #1995
How has this been tested?
Screenshots (if appropriate)
With 6 suggestions:
With 12 suggestions:
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)docs- improvements to any documentation content for users)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms