Skip to content

fix: Enable 'High priority' to be selected easily in Auto Suggest #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: Enable 'High priority' to be selected easily in Auto Suggest #1996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Getting Started/Auto-Suggest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,10 @@ Similarly, you can type some fraction of the word `start` (of whatever length is
| Searchable Text | Text that is added |
| ----------------------------- | -------------------------- |
| ⏎ | \<new line> |
| 🔺 highest priority | 🔺 |
| ⏫ high priority | ⏫ |
| 🔼 medium priority | 🔼 |
| 🔽 low priority | 🔽 |
| 🔺 highest priority | 🔺 |
| ⏬️ lowest priority | ⏬️ |
| 🔁 recurring (repeat) | 🔁 |
| every | 🔁 every |
Expand Down
8 changes: 4 additions & 4 deletions src/Suggestor/Suggestor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ function addTaskPropertySuggestions(
appendText: `${symbols.scheduledDateSymbol} `,
});
if (!hasPriority(line)) {
genericSuggestions.push({
displayText: `${symbols.prioritySymbols.Highest} highest priority`,
appendText: `${symbols.prioritySymbols.Highest} `,
});
genericSuggestions.push({
displayText: `${symbols.prioritySymbols.High} high priority`,
appendText: `${symbols.prioritySymbols.High} `,
Expand All @@ -99,6 +95,10 @@ function addTaskPropertySuggestions(
displayText: `${symbols.prioritySymbols.Low} low priority`,
appendText: `${symbols.prioritySymbols.Low} `,
});
genericSuggestions.push({
displayText: `${symbols.prioritySymbols.Highest} highest priority`,
appendText: `${symbols.prioritySymbols.Highest} `,
});
genericSuggestions.push({
displayText: `${symbols.prioritySymbols.Lowest} lowest priority`,
appendText: `${symbols.prioritySymbols.Lowest} `,
Expand Down
2 changes: 1 addition & 1 deletion ....test.auto-complete_with__dataview__symbols_show_all_suggested_text.approved.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
| due:: due date | due:: |
| start:: start date | start:: |
| scheduled:: scheduled date | scheduled:: |
| priority:: highest highest priority | priority:: highest |
| priority:: high high priority | priority:: high |
| priority:: medium medium priority | priority:: medium |
| priority:: low low priority | priority:: low |
| priority:: highest highest priority | priority:: highest |
| priority:: lowest lowest priority | priority:: lowest |
| repeat:: recurring (repeat) | repeat:: |
| created:: created today (2022-07-11) | created:: 2022-07-11 |
Expand Down
2 changes: 1 addition & 1 deletion ...tor.test.auto-complete_with__emoji__symbols_show_all_suggested_text.approved.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
| 📅 due date | 📅 |
| 🛫 start date | 🛫 |
| ⏳ scheduled date | ⏳ |
| 🔺 highest priority | 🔺 |
| ⏫ high priority | ⏫ |
| 🔼 medium priority | 🔼 |
| 🔽 low priority | 🔽 |
| 🔺 highest priority | 🔺 |
| ⏬ lowest priority | ⏬ |
| 🔁 recurring (repeat) | 🔁 |
| ➕ created today (2022-07-11) | ➕ 2022-07-11 |
Expand Down
2 changes: 1 addition & 1 deletion tests/Suggestor/Suggestor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ describe.each([
{ displayText: `${dueDateSymbol} due date`, appendText: `${dueDateSymbol} ` },
{ displayText: `${startDateSymbol} start date`, appendText: `${startDateSymbol} ` },
{ displayText: `${scheduledDateSymbol} scheduled date`, appendText: `${scheduledDateSymbol} ` },
{ displayText: `${prioritySymbols.Highest} highest priority`, appendText: `${prioritySymbols.Highest} ` },
{ displayText: `${prioritySymbols.High} high priority`, appendText: `${prioritySymbols.High} ` },
{ displayText: `${prioritySymbols.Medium} medium priority`, appendText: `${prioritySymbols.Medium} ` },
]);
});

Expand Down