Skip to content

Conversation

@eleanorfrajka
Copy link
Collaborator

@eleanorfrajka eleanorfrajka commented Mar 12, 2025

This is a draft pull request which will likely not be merged as is. I'm adding it to make the branch available.

Changes include: variable renaming including:
In convertOG1.convert_to_OG1()

  • datasets --> list_of_datasets - so the reader knows it's a python list
  • sg_cal --> ds_sgcal - so the reader knows it's an xarray dataset
  • dc_other --> ds_other - so the reader knows it's an xarray dataset
  • dc_log --> ds_log - so the reader knows it's an xarray dataset
  • ds1 / ds --> ds1_base - so the reader knows it's an xarray dataset of the basestation data rather than OG1 formatted data
  • sgdata --> ds_sgdatapoint - so the reader knows it's an xarray dataset with main dimension sg_data_point

Creating a way to more easily see what is in a basestation file (besides loading the data and manually checking). So there is a new "development notebook" in notebooks/dev_notebooks/ called parse_basestn.ipynb which uses functions in seagliderOG1/parsers.py. These include:

  • parsers.parse_basestation() is created to parse the information in the original basestation file. I realised that we could have sensor data that is not passed through the seagliderOG1 conversion because the sensor name isn't something we've come across yet. So we need some way to identify what all is in a basestation file (in a human readable format, e.g. a yaml).
  • This creates in data/ the info_*.yaml files
    It's not foolproof yet - i.e., it doesn't generate a complete list of everything so that we can identify whether there are unexpected variable names which aren't being processed. But for development purposes, it's giving a human readable way to check a range of basestation formats and see what's going funny.

--> to this, should add the glider that's causing processing problems.

@eleanorfrajka eleanorfrajka marked this pull request as draft March 12, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant