Draft pull - with refactor & creating readable yaml of basestation attributes #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request which will likely not be merged as is. I'm adding it to make the branch available.
Changes include: variable renaming including:
In
convertOG1.convert_to_OG1()datasets-->list_of_datasets- so the reader knows it's a python listsg_cal-->ds_sgcal- so the reader knows it's an xarray datasetdc_other-->ds_other- so the reader knows it's an xarray datasetdc_log-->ds_log- so the reader knows it's an xarray datasetds1/ds-->ds1_base- so the reader knows it's an xarray dataset of the basestation data rather than OG1 formatted datasgdata-->ds_sgdatapoint- so the reader knows it's an xarray dataset with main dimensionsg_data_pointCreating a way to more easily see what is in a basestation file (besides loading the data and manually checking). So there is a new "development notebook" in
notebooks/dev_notebooks/calledparse_basestn.ipynbwhich uses functions inseagliderOG1/parsers.py. These include:parsers.parse_basestation()is created to parse the information in the original basestation file. I realised that we could have sensor data that is not passed through the seagliderOG1 conversion because the sensor name isn't something we've come across yet. So we need some way to identify what all is in a basestation file (in a human readable format, e.g. a yaml).data/theinfo_*.yamlfilesIt's not foolproof yet - i.e., it doesn't generate a complete list of everything so that we can identify whether there are unexpected variable names which aren't being processed. But for development purposes, it's giving a human readable way to check a range of basestation formats and see what's going funny.
--> to this, should add the glider that's causing processing problems.