[IMP] dv: autofocus input #7252
Conversation
|
|
| false | ||
| )}`; | ||
| const message = () => { | ||
| if (this.isNot && pass) { |
There was a problem hiding this comment.
can we do something generic ? All of the other custom matchers are also wrong ...
There was a problem hiding this comment.
let's do this in another task
| () => { | ||
| if (this.props.focused) { | ||
| this.inputRef.el!.focus(); | ||
| if (this.props.focused && this.inputRef.el) { |
There was a problem hiding this comment.
... can the input ref really be undefiend at useEffect ? Or is it just to avoid ! ?
There was a problem hiding this comment.
yes, if the input isn't displayed because it's a composer instead
|
|
||
| onCriterionTypeChanged(type: DataValidationCriterionType) { | ||
| this.state.rule.criterion.type = type; | ||
| this.state.isTypeUpdated = true; |
There was a problem hiding this comment.
we should probably have the same behaviour for CFs and in the data filter menu, no ? To confirm with frgi, but I don't see why implement it in DVs but not CFs
LucasLefevre
force-pushed
the
master-dv-input-focus-lul
branch
from
b2a14ee to
2fe397c
Compare
| false | ||
| )}`; | ||
| const message = () => { | ||
| if (this.isNot && pass) { |
There was a problem hiding this comment.
let's do this in another task
|
|
||
| onCriterionTypeChanged(type: DataValidationCriterionType) { | ||
| this.state.rule.criterion.type = type; | ||
| this.state.isTypeUpdated = true; |
When switching a data validation to "Value In Range", automatically focus the range input to allow selecting a range right away without an additional click to focus the input. We do the same for all validation types that have an associated input. Task: 4862354
Task: 4862354
Task: 4862354
LucasLefevre
force-pushed
the
master-dv-input-focus-lul
branch
from
2fe397c to
e011499
Compare
| t-key="state.rules.cellIs.operator" | ||
| criterion="genericCriterion" | ||
| onCriterionChanged.bind="onRuleValuesChanged" | ||
| autofocus="this.state.hasEditedCf" |
There was a problem hiding this comment.
Do you think it makes sense to add it for other CF as well ?
For instance ColorScale has a set iof inputs -
and so does Icon set (but that one is a bit far fetched
There was a problem hiding this comment.
from a functional POV, probably yes it makes sense. From a technical POV, is it worth it ? I don't know...
There was a problem hiding this comment.
let's keep it as it is for now then
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
Part-of: #7252 Signed-off-by: Rémi Rahir (rar) <[email protected]>
When switching a data validation to "Value In Range", automatically focus the range input to allow selecting a range right away without an additional click to focus the input. We do the same for all validation types that have an associated input. Task: 4862354 Part-of: #7252 Signed-off-by: Rémi Rahir (rar) <[email protected]>
Task: 4862354 Part-of: #7252 Signed-off-by: Rémi Rahir (rar) <[email protected]>
closes #7252 Task: 4862354 Signed-off-by: Rémi Rahir (rar) <[email protected]>
4 participants
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4862354
review checklist