Skip to content

[IMP] dv: autofocus input #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: Create generator-generic-ossf-slsa3-publish.yml
wants to merge 4 commits into from
Closed

[IMP] dv: autofocus input #7252

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e324dd
[IMP] tests: add .not.toHaveClass() failure message
LucasLefevre Oct 3, 2025
9b61f24
[IMP] DV: auto focus input
LucasLefevre Oct 3, 2025
6f424f5
[IMP] CF: auto focus input
LucasLefevre Oct 13, 2025
e011499
[IMP] filters: auto focus input
LucasLefevre Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/side_panel/conditional_formatting/cf_editor/cell_is_rule_editor.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
t-key="state.rules.cellIs.operator"
criterion="genericCriterion"
onCriterionChanged.bind="onRuleValuesChanged"
autofocus="this.state.hasEditedCf"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to add it for other CF as well ?
For instance ColorScale has a set iof inputs -
image
and so does Icon set (but that one is a bit far fetched

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a functional POV, probably yes it makes sense. From a technical POV, is it worth it ? I don't know...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it as it is for now then

/>

<div class="o-section-subtitle pt-3">Formatting style</div>
Expand Down
2 changes: 2 additions & 0 deletions tests/conditional_formatting/conditional_formatting_panel_component.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,9 @@ describe("UI of conditional formats", () => {

// change every value
setInputValueAndTrigger(selectors.ruleEditor.range, "A1:A3");
expect(".o-composer").not.toHaveClass("active");
await changeRuleOperatorType(fixture, "beginsWithText");
expect(".o-composer").toHaveClass("active");
editStandaloneComposer(selectors.ruleEditor.editor.valueInput, "3");

await click(fixture, selectors.ruleEditor.editor.bold);
Expand Down