Conversation
| } | ||
|
|
||
| .c-mutation { | ||
| .c-mutation-menu-item { |
There was a problem hiding this comment.
This class name was changed leading to the icons in the menu to be lower opacity without this style
| <style scoped> | ||
| <style scoped lang="scss"> |
There was a problem hiding this comment.
Nested CSS does not yet have Baseline support: https://caniuse.com/css-nesting, can fix this by specifying SCSS
| <v-card class="c-mutation"> | ||
| <v-card | ||
| class="c-mutation" | ||
| variant="flat" |
There was a problem hiding this comment.
The card had unwanted shadows when in the lumino tab view unless set to the flat variant
| layoutWatcher.pause() | ||
| // Register with Lumino that the dock panel is no longer used, | ||
| // otherwise uncaught errors can occur when restoring layout | ||
| dockPanel.dispose() |
There was a problem hiding this comment.
I didn't quite get to the bottom of cylc#2394 (comment), but the layout watcher was for some reason being triggered after the dock panel was disposed. Not sure why, I investigated if it was due to the FormGenerator changing its parent v-model but am not convinced that's the cause. At least I think it makes sense to stop the layout watcher before disposing of the dock panel.
2 participants
No description provided.