Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/components/cylc/Mutation.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
-->

<template>
<!-- Have to repeat these defaults as the ones set in App.vue don't make it through
the parent v-dialog - see https://github.com/vuetifyjs/vuetify/issues/18123 -->
<v-card class="c-mutation">
<v-card
class="c-mutation"
variant="flat"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card had unwanted shadows when in the lumino tab view unless set to the flat variant

>
<!-- the mutation title -->
<template v-slot:title>
{{ mutation._title }}
Expand All @@ -38,6 +39,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
</template>

<v-card-text class="card-text py-0 px-4">
<!-- Have to repeat these defaults as the ones set in App.vue don't make it through
the parent v-dialog - see https://github.com/vuetifyjs/vuetify/issues/18123 -->
<v-defaults-provider :defaults="vuetifyDefaults">
<!-- the mutation description -->
<v-expansion-panels
Expand Down Expand Up @@ -324,13 +327,13 @@ export default {
}
</script>

<style scoped>
<style scoped lang="scss">
Comment on lines -327 to +330
Copy link
Author

@MetRonnie MetRonnie Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested CSS does not yet have Baseline support: https://caniuse.com/css-nesting, can fix this by specifying SCSS

/* the body should scroll, the title and actions should remain fixed */
.c-mutation {
display: flex;
flex-direction: column;

.card-text{
.card-text {
overflow-y: auto;
}
}
Expand Down
4 changes: 1 addition & 3 deletions src/components/cylc/workspace/Lumino.vue
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ onBeforeUnmount(() => {
eventBus.off('add-view', addView)
eventBus.off('lumino:deleted', onWidgetDeleted)
eventBus.off('reset-workspace-layout', resetToDefault)
layoutWatcher.pause()
// Register with Lumino that the dock panel is no longer used,
// otherwise uncaught errors can occur when restoring layout
dockPanel.dispose()
Comment on lines +147 to 150
Copy link
Author

@MetRonnie MetRonnie Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite get to the bottom of cylc#2394 (comment), but the layout watcher was for some reason being triggered after the dock panel was disposed. Not sure why, I investigated if it was due to the FormGenerator changing its parent v-model but am not convinced that's the cause. At least I think it makes sense to stop the layout watcher before disposing of the dock panel.

Expand Down Expand Up @@ -192,9 +193,6 @@ async function getLayout () {
* Save the current layout/views to cache storage.
*/
async function saveLayout () {
if (!dockPanel.layout) {
return // dockPanel not yet initialised
}
// Serialize layout first to synchronously capture the current state
const serializedLayout = JSON.stringify({
layout: dockPanel.saveLayout(),
Expand Down
2 changes: 1 addition & 1 deletion src/styles/cylc/_menu.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
white-space: normal;
}

.c-mutation {
.c-mutation-menu-item {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class name was changed leading to the icons in the menu to be lower opacity without this style

.v-list-item__prepend > .v-icon {
opacity: 1;
}
Expand Down