-
Notifications
You must be signed in to change notification settings - Fork 0
Mutation editor #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutation editor #125
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,9 +16,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |
| --> | ||
|
|
||
| <template> | ||
| <!-- Have to repeat these defaults as the ones set in App.vue don't make it through | ||
| the parent v-dialog - see https://github.com/vuetifyjs/vuetify/issues/18123 --> | ||
| <v-card class="c-mutation"> | ||
| <v-card | ||
| class="c-mutation" | ||
| variant="flat" | ||
| > | ||
| <!-- the mutation title --> | ||
| <template v-slot:title> | ||
| {{ mutation._title }} | ||
|
|
@@ -38,6 +39,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |
| </template> | ||
|
|
||
| <v-card-text class="card-text py-0 px-4"> | ||
| <!-- Have to repeat these defaults as the ones set in App.vue don't make it through | ||
| the parent v-dialog - see https://github.com/vuetifyjs/vuetify/issues/18123 --> | ||
| <v-defaults-provider :defaults="vuetifyDefaults"> | ||
| <!-- the mutation description --> | ||
| <v-expansion-panels | ||
|
|
@@ -324,13 +327,13 @@ export default { | |
| } | ||
| </script> | ||
|
|
||
| <style scoped> | ||
| <style scoped lang="scss"> | ||
|
Comment on lines
-327
to
+330
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nested CSS does not yet have Baseline support: https://caniuse.com/css-nesting, can fix this by specifying SCSS |
||
| /* the body should scroll, the title and actions should remain fixed */ | ||
| .c-mutation { | ||
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| .card-text{ | ||
| .card-text { | ||
| overflow-y: auto; | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,6 +144,7 @@ onBeforeUnmount(() => { | |
| eventBus.off('add-view', addView) | ||
| eventBus.off('lumino:deleted', onWidgetDeleted) | ||
| eventBus.off('reset-workspace-layout', resetToDefault) | ||
| layoutWatcher.pause() | ||
| // Register with Lumino that the dock panel is no longer used, | ||
| // otherwise uncaught errors can occur when restoring layout | ||
| dockPanel.dispose() | ||
|
Comment on lines
+147
to
150
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't quite get to the bottom of cylc#2394 (comment), but the layout watcher was for some reason being triggered after the dock panel was disposed. Not sure why, I investigated if it was due to the FormGenerator changing its parent v-model but am not convinced that's the cause. At least I think it makes sense to stop the layout watcher before disposing of the dock panel. |
||
|
|
@@ -192,9 +193,6 @@ async function getLayout () { | |
| * Save the current layout/views to cache storage. | ||
| */ | ||
| async function saveLayout () { | ||
| if (!dockPanel.layout) { | ||
| return // dockPanel not yet initialised | ||
| } | ||
| // Serialize layout first to synchronously capture the current state | ||
| const serializedLayout = JSON.stringify({ | ||
| layout: dockPanel.saveLayout(), | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| white-space: normal; | ||
| } | ||
|
|
||
| .c-mutation { | ||
| .c-mutation-menu-item { | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This class name was changed leading to the icons in the menu to be lower opacity without this style |
||
| .v-list-item__prepend > .v-icon { | ||
| opacity: 1; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The card had unwanted shadows when in the lumino tab view unless set to the flat variant