Conversation
jburel
commented
Mar 20, 2025
- Update actions
- Fix internal dependency
- Remove Java 1.8 support. This no longer works
|
https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/341/ is back to green |
|
👍 Thanks JM, looks good to me! |
Is this bumping the build requirement to JDK 11 (as we already do on the omero-* components) or the Java runtime requirement? I know we talked about this several times recently, is there a summary of the state of the current packaging issues (might even be a blog post on the OME website)? |
|
The compatibility does not work for insight with CI #333 |
sbesson
left a comment
There was a problem hiding this comment.
Coming back to this as the latest OMERO.insight is behind in terms of omero-gateway version and does not include the Bio-Formats reader addition and fixes matching the latest OMERO.server release
build.gradle
Outdated
| java { | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 | ||
| targetCompatibility = JavaVersion.VERSION_1_8 | ||
| sourceCompatibility = JavaVersion.VERSION_11 |
There was a problem hiding this comment.
Assuming JDK 11 is a build requirement only like the other OMERO components, would setting
compileJava {
options.release = 8
}
be an option here as in https://github.com/ome/omero-model/blob/560fde3c5f344ee4ba5d25c3201b71f3e12adbd0/build.gradle#L32-L34
sbesson
left a comment
There was a problem hiding this comment.
From a pure infrastructure perspective, the builds are passing, the actions version bump make sense and the usage of Java 11 at build time is consistent with the other OMERO Java components.
Is there a way to review these changes functionally. The packaged artifacts are only built on tags and the OME CI job is producing a zip which fails with java.lang.ExceptionInInitializerError when I try to execute omero-insight
|
The same command that the one runs via CI done locally generates an artifact that works. This requires investigation |
|
I think I have found the source of the problem. The gradle version is 6.9.3. It works with 6.8.2 which is the version I have been using locally. I am going to modify the version on merge -CI. https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/28/ should create usable artefacts. |
sbesson
left a comment
There was a problem hiding this comment.
Retested the artifacts built nightly on https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/. I can successfully launch OMERO.insight using the executable.
@jburel suggests this was related to the version of Gradle used in this CI environment. As discussed earlier, merging this to unblock other work. Moving forward, we can possibly look into adding the Gradle wrapper infrastructure to pin the version expected by the current build system.