Skip to content

Update infra#461

Merged
sbesson merged 9 commits intoome:masterfrom
jburel:gha_update
Jan 27, 2026
Merged

Update infra#461
sbesson merged 9 commits intoome:masterfrom
jburel:gha_update

Conversation

@jburel
Copy link
Member

@jburel jburel commented Mar 20, 2025

  • Update actions
  • Fix internal dependency
  • Remove Java 1.8 support. This no longer works

@jburel
Copy link
Member Author

jburel commented Mar 21, 2025

@dominikl
Copy link
Member

👍 Thanks JM, looks good to me!

@sbesson
Copy link
Member

sbesson commented Mar 21, 2025

Remove Java 1.8 support. This no longer works

Is this bumping the build requirement to JDK 11 (as we already do on the omero-* components) or the Java runtime requirement? I know we talked about this several times recently, is there a summary of the state of the current packaging issues (might even be a blog post on the OME website)?

@jburel
Copy link
Member Author

jburel commented Mar 21, 2025

The compatibility does not work for insight with CI #333
This is a build requirement

@pwalczysko pwalczysko mentioned this pull request Mar 28, 2025
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming back to this as the latest OMERO.insight is behind in terms of omero-gateway version and does not include the Bio-Formats reader addition and fixes matching the latest OMERO.server release

build.gradle Outdated
java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming JDK 11 is a build requirement only like the other OMERO components, would setting

compileJava {
    options.release = 8
}

be an option here as in https://github.com/ome/omero-model/blob/560fde3c5f344ee4ba5d25c3201b71f3e12adbd0/build.gradle#L32-L34

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a pure infrastructure perspective, the builds are passing, the actions version bump make sense and the usage of Java 11 at build time is consistent with the other OMERO Java components.

Is there a way to review these changes functionally. The packaged artifacts are only built on tags and the OME CI job is producing a zip which fails with java.lang.ExceptionInInitializerError when I try to execute omero-insight

@jburel
Copy link
Member Author

jburel commented Jan 23, 2026

The same command that the one runs via CI done locally generates an artifact that works. This requires investigation

@jburel
Copy link
Member Author

jburel commented Jan 23, 2026

I think I have found the source of the problem. The gradle version is 6.9.3. It works with 6.8.2 which is the version I have been using locally. I am going to modify the version on merge -CI.

https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/28/ should create usable artefacts.

@sbesson sbesson self-requested a review January 27, 2026 13:21
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested the artifacts built nightly on https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/. I can successfully launch OMERO.insight using the executable.

@jburel suggests this was related to the version of Gradle used in this CI environment. As discussed earlier, merging this to unblock other work. Moving forward, we can possibly look into adding the Gradle wrapper infrastructure to pin the version expected by the current build system.

@sbesson sbesson merged commit 5fc066d into ome:master Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants