Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #273

viki435 · 2025-08-12T09:54:51Z

Primary JIRA: VLCLJ-2513
Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577
Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules.

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

vishnu-khanth · 2025-08-14T05:55:26Z

build seems to be failing

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

vishnu-khanth · 2025-08-20T06:08:21Z

Conflicts have to be resolved in this PR!

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Copilot

Pull Request Overview

This PR fixes GTEST_FAIL logic for multi-device scenarios across power, performance, and scheduler modules. The key changes ensure that tests fail only when all devices lack support, rather than failing immediately when a single device doesn't support the feature.

Key changes:

Added class-level boolean flags to track if any device supports the feature
Replaced immediate failure on unsupported features with logging and continued iteration
Added final check to fail only if no devices support the feature across all devices

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
test_sysman_scheduler.cpp	Added `is_scheduler_supported` flag and refactored failure logic to check all devices before failing
test_sysman_power.cpp	Added `is_power_supported` flag and updated failure handling for multi-device power testing
test_sysman_performance.cpp	Added `is_performance_supported` flag and modified failure logic for performance module testing

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

conformance_tests/sysman/test_sysman_power/src/test_sysman_power.cpp

vishnu-khanth · 2025-08-22T08:54:33Z

conformance_tests/sysman/test_sysman_performance/src/test_sysman_performance.cpp

@@ -266,27 +316,34 @@ class PerformanceModuleParamComputePerformanceFactorTest
 LZT_TEST_P(
    PERFORMANCE_COMPUTE_TEST,
    GivenValidPerformanceHandleWhenSettingMultiplePerformanceFactorForComputeThenValidPerformanceFactorIsReturned) {
+  bool is_perf_supported = false;


why is it defined inside the test?
it should be added in class PerformanceModuleParamComputePerformanceFactorZesTest & PerformanceModuleParamComputePerformanceFactorTest

and can be renamed to is_performance_supported to maintain consistency in this entire file

vishnu-khanth · 2025-08-22T09:06:42Z

conformance_tests/sysman/test_sysman_power/src/test_sysman_power.cpp

-                    power_sustained_set.limitValueLocked);
-          EXPECT_EQ(power_sustained_get.interval, power_sustained_set.interval);
-          EXPECT_EQ(power_sustained_get.limit, power_sustained_set.limit);
+          EXPECT_EQ(power_peak_get.limitValueLocked,


why power_sustained is changed to power_peak ?

vishnu-khanth · 2025-08-22T09:07:09Z

conformance_tests/sysman/test_sysman_power/src/test_sysman_power.cpp

@@ -607,298 +764,229 @@ LZT_TEST_F(
          }
          EXPECT_ZE_RESULT_SUCCESS(status);
        } else {
-          LOG_INFO << "Set limit not supported due to sustained "
+          LOG_INFO << "Set limit not supported due to peak "


similarly here. why sustained is changed to peak ?

vishnu-khanth · 2025-08-22T09:08:21Z

conformance_tests/sysman/test_sysman_power/src/test_sysman_power.cpp

@@ -607,298 +764,229 @@ LZT_TEST_F(
          }
          EXPECT_ZE_RESULT_SUCCESS(status);
        } else {
-          LOG_INFO << "Set limit not supported due to sustained "
+          LOG_INFO << "Set limit not supported due to peak "


can you make sure that in this file only gtest_fail logic is changed.
other functional test logic should not be changed

…erformance and scheduler modules. Primary JIRA: VLCLJ-2513 Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Signed-off-by: viki435 <[email protected]>

Signed-off-by: viki435 <[email protected]>

vishnu-khanth · 2025-08-25T10:49:26Z

This PR can be closed since a new one is raised #284

Primary JIRA: VLCLJ-2513

3f4c5eb

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

viki435 requested review from AshwinKumarKulkarni and vishnu-khanth August 12, 2025 09:55

viki435 added 3 commits August 18, 2025 23:25

Primary JIRA: VLCLJ-2513

a292569

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Primary JIRA: VLCLJ-2513

d029dda

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Primary JIRA: VLCLJ-2513

e32b567

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

vishnu-khanth requested a review from Copilot August 19, 2025 09:14

This comment was marked as outdated.

Sign in to view

vishnu-khanth requested a review from Copilot August 20, 2025 06:04

This comment was marked as outdated.

Sign in to view

viki435 and others added 7 commits August 21, 2025 00:35

Primary JIRA: VLCLJ-2513

d53fa37

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Primary JIRA: VLCLJ-2513

dc13726

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Primary JIRA: VLCLJ-2513

b8f0f52

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Merge branch 'master' into power_perf_scheduler_branch_v2

53ccb3b

Primary JIRA: VLCLJ-2513

125964d

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Primary JIRA: VLCLJ-2513

38648aa

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

Primary JIRA: VLCLJ-2513

3115eed

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

vishnu-khanth requested a review from Copilot August 21, 2025 05:50

This comment was marked as outdated.

Sign in to view

vishnu-khanth requested a review from Copilot August 22, 2025 07:03

This comment was marked as outdated.

Sign in to view

Primary JIRA: VLCLJ-2513

e26691c

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

vishnu-khanth requested a review from Copilot August 22, 2025 08:34

Primary JIRA: VLCLJ-2513

d43887b

Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules. Signed-off-by: viki435 <[email protected]>

This comment was marked as outdated.

Sign in to view

vishnu-khanth requested a review from Copilot August 22, 2025 08:42

Copilot AI reviewed Aug 22, 2025

View reviewed changes

conformance_tests/sysman/test_sysman_power/src/test_sysman_power.cpp Outdated Show resolved Hide resolved

vishnu-khanth reviewed Aug 22, 2025

View reviewed changes

viki435 added 3 commits August 22, 2025 17:10

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, p…

c5cf969

…erformance and scheduler modules. Primary JIRA: VLCLJ-2513 Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Signed-off-by: viki435 <[email protected]>

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, p…

9a74f27

…erformance and scheduler modules. Primary JIRA: VLCLJ-2513 Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Signed-off-by: viki435 <[email protected]>

Reverting the code as conflicts are seen.

58d06c2

Signed-off-by: viki435 <[email protected]>

viki435 force-pushed the power_perf_scheduler_branch_v2 branch from f749ec5 to 58d06c2 Compare August 25, 2025 06:19

viki435 closed this Aug 25, 2025

viki435 mentioned this pull request Aug 25, 2025

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #284

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #273

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #273

Uh oh!

viki435 commented Aug 12, 2025

Uh oh!

vishnu-khanth commented Aug 14, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

vishnu-khanth commented Aug 20, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

vishnu-khanth Aug 22, 2025

Uh oh!

vishnu-khanth Aug 22, 2025

Uh oh!

vishnu-khanth Aug 22, 2025

Uh oh!

vishnu-khanth Aug 22, 2025

Uh oh!

vishnu-khanth commented Aug 25, 2025

Uh oh!

Uh oh!

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #273

Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #273

Uh oh!

Conversation

viki435 commented Aug 12, 2025

Uh oh!

vishnu-khanth commented Aug 14, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

vishnu-khanth commented Aug 20, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

vishnu-khanth Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

vishnu-khanth Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

vishnu-khanth Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

vishnu-khanth Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

vishnu-khanth commented Aug 25, 2025

Uh oh!

Uh oh!