Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erformance and scheduler modules. Primary JIRA: VLCLJ-2513 Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577 Signed-off-by: viki435 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes GTEST_FAIL logic for handling multi-device scenarios in power, performance, and scheduler test modules. The changes ensure that tests only fail when no handles are found across all devices, rather than failing when a single device lacks support.
- Updated test classes to track feature support across devices with boolean flags
- Modified failure logic to accumulate support status and only fail if no devices support the feature
- Improved logging to provide clearer information about device-specific support status
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| test_sysman_scheduler.cpp | Added is_scheduler_supported flag and updated all test functions to track support across devices |
| test_sysman_power.cpp | Added is_power_supported flag and updated all test functions to track support across devices |
| test_sysman_performance.cpp | Added is_performance_supported flag and updated all test functions to track support across devices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vishnu-khanth
approved these changes
Aug 25, 2025
|
LGTM! |
viki435
requested review from
AshwinKumarKulkarni and
narenbagria
and removed request for
Copilot
|
Refer #273 for comments. |
narenbagria
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary JIRA: VLCLJ-2513
Sub-tasks: VLCLJ-2570, VLCLJ-2568, VLCLJ-2577
Fix: Handling GTEST_FAIL logic for multi-device scenario for power, performance and scheduler modules.