SLES15 SUPPORT #1000
SLES15 SUPPORT #1000
Conversation
| name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}" | ||
| # run only on upstream; forks will not have the HW | ||
| if: github.repository == 'oneapi-src/unified-memory-framework' | ||
| #if: github.repository == 'oneapi-src/unified-memory-framework' |
There was a problem hiding this comment.
I suppose it should not be commented out
There was a problem hiding this comment.
Why have you commented it out?
There was a problem hiding this comment.
ok, commented for testing purpose
There was a problem hiding this comment.
Please do not resolve issues on your own. The issue is always resolved by the submitter.
There was a problem hiding this comment.
ok, commented for testing purpose
If it is just for testing then you should:
- convert this PR to draft (since it is not read yet)
- use a temporary patch like ldorau@a590c27 on my
DEBUG_CI_run_only_multi_numabranch to test only one CI job that you are changing and do not occupy other resources, when you do not need them (the resources in public UMF CI are very limited).
| - name: Run tests (on SLES15) | ||
| if: matrix.os == 'sles15' | ||
| working-directory: ${{github.workspace}}/build | ||
| run: | | ||
| ctest --output-on-failure --test-dir test -E "umf-provider_os_memory_multiple_numa_nodes" | ||
| ./test/umf_test-provider_os_memory_multiple_numa_nodes \ | ||
| --gtest_filter="-*checkModeLocal/*:*checkModePreferredEmptyNodeset/*:testNuma.checkModeInterleave" |
There was a problem hiding this comment.
I cannot see any difference between 'rhel-9.1' and 'sles15', so why there are two separate cases?
ldorau
left a comment
ldorau
left a comment
There was a problem hiding this comment.
Please squash 3 commits:
into one and add an appropriate description like "Add SLES15 to multi-NUMA CI"
|
|
||
| - name: Run tests | ||
| if: matrix.os != 'rhel-9.1' | ||
| if: (matrix.os != 'rhel-9.1') && (matrix.os != 'sles15') |
There was a problem hiding this comment.
I would run all tests on SLES - did it not work? can you send some logs with failing SLES on all tests?
| name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}" | ||
| # run only on upstream; forks will not have the HW | ||
| if: github.repository == 'oneapi-src/unified-memory-framework' | ||
| #if: github.repository == 'oneapi-src/unified-memory-framework' |
There was a problem hiding this comment.
when done testing, pls un-comment this
4 participants
SLES15 SUPPORT