Skip to content

SLES15 SUPPORT #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

SLES15 SUPPORT #1000

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8295a6
Update reusable_multi_numa.yml
opensource-krzysztof Dec 17, 2024
430e4d5
Update reusable_multi_numa.yml
opensource-krzysztof Dec 17, 2024
8ffd2b5
Update reusable_multi_numa.yml
opensource-krzysztof Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/reusable_multi_numa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
multi_numa:
name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}"
# run only on upstream; forks will not have the HW
if: github.repository == 'oneapi-src/unified-memory-framework'
#if: github.repository == 'oneapi-src/unified-memory-framework'
Copy link
Contributor

@ldorau ldorau Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it should not be commented out

Copy link
Contributor

@ldorau ldorau Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you commented it out?

Copy link
Contributor Author

@opensource-krzysztof opensource-krzysztof Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, commented for testing purpose

Copy link
Contributor

@ldorau ldorau Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not resolve issues on your own. The issue is always resolved by the submitter.

Copy link
Contributor

@ldorau ldorau Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, commented for testing purpose

If it is just for testing then you should:

  1. convert this PR to draft (since it is not read yet)
  2. use a temporary patch like ldorau@a590c27 on my DEBUG_CI_run_only_multi_numa branch to test only one CI job that you are changing and do not occupy other resources, when you do not need them (the resources in public UMF CI are very limited).

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when done testing, pls un-comment this


strategy:
matrix:
os: [ubuntu-22.04, rhel-9.1]
os: [ubuntu-22.04, rhel-9.1, sles15]
build_type: [Debug, Release]
shared_library: ['ON', 'OFF']
runs-on: ["DSS-MULTI-NUMA", "DSS-${{matrix.os}}"]
Expand Down Expand Up @@ -53,13 +53,20 @@ jobs:
run: cmake --build ${{github.workspace}}/build -j $(nproc)

- name: Run tests
if: matrix.os != 'rhel-9.1'
if: (matrix.os != 'rhel-9.1') && (matrix.os != 'sles15')
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would run all tests on SLES - did it not work? can you send some logs with failing SLES on all tests?

working-directory: ${{github.workspace}}/build
run: ctest --output-on-failure --test-dir test

# On RHEL, hwloc version is just a little too low.
# Skip some tests until we upgrade hwloc and update CMake to properly handle local hwloc installation.
# TODO: fix issue #560
- name: Run tests (on SLES15)
if: matrix.os == 'sles15'
working-directory: ${{github.workspace}}/build
run: |
ctest --output-on-failure --test-dir test -E "umf-provider_os_memory_multiple_numa_nodes"
./test/umf_test-provider_os_memory_multiple_numa_nodes \
--gtest_filter="-*checkModeLocal/*:*checkModePreferredEmptyNodeset/*:testNuma.checkModeInterleave"
Comment on lines +63 to +69
Copy link
Contributor

@ldorau ldorau Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any difference between 'rhel-9.1' and 'sles15', so why there are two separate cases?

- name: Run tests (on RHEL)
if: matrix.os == 'rhel-9.1'
working-directory: ${{github.workspace}}/build
Expand Down
Loading