Fix handling resident_device_handles in L0 provider #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Oct 1, 2024
lukaszstolarczuk
approved these changes
Oct 1, 2024
|
I've hit re-run on the CI gpu job - examples failed with SegFault. It seems two L0 examples failed now. |
vinser52
reviewed
Oct 1, 2024
Probably it is because of the issue with not initialized |
igchor
force-pushed
the
l0_provider_residency
branch
from
15cfb8d to
4db498a
Compare
vinser52
approved these changes
Oct 1, 2024
handles were being ignored in the initialize function.
igchor
force-pushed
the
l0_provider_residency
branch
from
4db498a to
df7650b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles were being ignored in the initialize function.
Unfortunetaly there is no easy way to test the residency here. I'm working on a test in UR repo for that.