Skip to content

Fix handling resident_device_handles in L0 provider #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmark/ubench.c
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ int create_level_zero_params(level_zero_memory_provider_params_t *params) {
UBENCH_EX(ipc, disjoint_pool_with_level_zero_provider) {
const size_t BUFFER_SIZE = 100;
const size_t N_BUFFERS = 1000;
level_zero_memory_provider_params_t level_zero_params;
level_zero_memory_provider_params_t level_zero_params = {0};

int ret = create_level_zero_params(&level_zero_params);
if (ret != 0) {
Expand Down
2 changes: 1 addition & 1 deletion examples/ipc_level_zero/ipc_level_zero.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ int create_level_zero_pool(ze_context_handle_t context,
ze_device_handle_t device,
umf_memory_pool_handle_t *pool) {
// setup params
level_zero_memory_provider_params_t params;
level_zero_memory_provider_params_t params = {0};
params.level_zero_context_handle = context;
params.level_zero_device_handle = device;
params.memory_type = UMF_MEMORY_TYPE_DEVICE;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ int main(void) {

// Setup parameters for the Level Zero memory provider. It will be used for
// allocating memory from Level Zero devices.
level_zero_memory_provider_params_t ze_memory_provider_params;
level_zero_memory_provider_params_t ze_memory_provider_params = {0};
ze_memory_provider_params.level_zero_context_handle = hContext;
ze_memory_provider_params.level_zero_device_handle = hDevice;
// Set the memory type to shared to allow the memory to be accessed on both
Expand Down
22 changes: 22 additions & 0 deletions src/provider/provider_level_zero.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,25 @@ static umf_result_t ze_memory_provider_initialize(void *params,
sizeof(ze_provider->device_properties));
}

if (ze_params->resident_device_count) {
ze_provider->resident_device_handles = umf_ba_global_alloc(
sizeof(ze_device_handle_t) * ze_params->resident_device_count);
if (!ze_provider->resident_device_handles) {
umf_ba_global_free(ze_provider);
return UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY;
}

ze_provider->resident_device_count = ze_params->resident_device_count;

for (uint32_t i = 0; i < ze_provider->resident_device_count; i++) {
ze_provider->resident_device_handles[i] =
ze_params->resident_device_handles[i];
}
} else {
ze_provider->resident_device_handles = NULL;
ze_provider->resident_device_count = 0;
}

*provider = ze_provider;

return UMF_RESULT_SUCCESS;
Expand All @@ -188,6 +207,9 @@ static void ze_memory_provider_finalize(void *provider) {
return;
}

ze_memory_provider_t *ze_provider = (ze_memory_provider_t *)provider;
umf_ba_global_free(ze_provider->resident_device_handles);

umf_ba_global_free(provider);
}

Expand Down
Loading