Skip to content

[CI] New workflows order part1 #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2024
Merged

[CI] New workflows order part1 #791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b866b7c
[CI] Rename sub-workflows with "reusable_" prefix
lukaszstolarczuk Oct 9, 2024
59e9dfc
[CI] Merge spell check with code style check into a single job
lukaszstolarczuk Oct 9, 2024
e7c3317
[CI] Run all Valgrind tools in a single job
lukaszstolarczuk Oct 9, 2024
f65a78e
[CI] Remove flag check in Windows' "Fast builds"
lukaszstolarczuk Oct 9, 2024
2ad5ace
[CI] Do Bandit scan only on Linux and move it to 'checks' workflow
lukaszstolarczuk Oct 9, 2024
0e235a7
[CI] Move CodeQL and Trivy back into PR/Push workflow
lukaszstolarczuk Oct 9, 2024
10b9391
[CI] Fix all pip installations
ldorau Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ jobs:
sudo apt-get update
sudo apt-get install -y doxygen

- name: Install pip requirements
run: python3 -m pip install -r third_party/requirements.txt
# Latest distros do not allow global pip installation
- name: Install Python requirements in venv
run: |
python3 -m venv .venv
. .venv/bin/activate
echo "$PATH" >> $GITHUB_PATH
python3 -m pip install -r third_party/requirements.txt

- name: Setup PATH for python
run: echo "$HOME/.local/bin" >> $GITHUB_PATH
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/reusable_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install -y black cmake clang-format-15 cmake-format libhwloc-dev

# Latest distros do not allow global pip installation
- name: Install Python requirements in venv
run: |
python3 -m venv .venv
. .venv/bin/activate
echo "$PATH" >> $GITHUB_PATH
python3 -m pip install bandit

- name: Configure CMake
Expand Down Expand Up @@ -50,6 +57,6 @@ jobs:
with:
config: ./.github/workflows/.spellcheck-conf.toml

# Run Bandit recursively, but omit _deps directory (with 3rd party code)
# Run Bandit recursively, but omit _deps directory (with 3rd party code) and python's venv
- name: Run Bandit
run: python3 -m bandit -r . -x '/_deps/'
run: python3 -m bandit -r . -x '/_deps/,/.venv/'
25 changes: 16 additions & 9 deletions .github/workflows/reusable_codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,27 +44,34 @@ jobs:
with:
languages: cpp

- name: Initialize vcpkg
if: ${{ matrix.os == 'windows-latest' }}
- name: "[Win] Initialize vcpkg"
if: matrix.os == 'windows-latest'
uses: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1 # v11.5
with:
vcpkgGitCommitId: 3dd44b931481d7a8e9ba412621fa810232b66289
vcpkgDirectory: ${{env.BUILD_DIR}}/vcpkg
vcpkgJsonGlob: '**/vcpkg.json'

- name: Install dependencies
if: ${{ matrix.os == 'windows-latest' }}
run: vcpkg install
shell: pwsh # Specifies PowerShell as the shell for running the script.
- name: "[Win] Install dependencies"
if: matrix.os == 'windows-latest'
run: |
vcpkg install
python3 -m pip install -r third_party/requirements.txt

- name: Install apt packages
- name: "[Lin] Install apt packages"
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get update
sudo apt-get install -y cmake clang libhwloc-dev libnuma-dev libjemalloc-dev libtbb-dev

- name: Install pip packages
run: python3 -m pip install -r third_party/requirements.txt
# Latest distros do not allow global pip installation
- name: "[Lin] Install Python requirements in venv"
if: matrix.os == 'ubuntu-latest'
run: |
python3 -m venv .venv
. .venv/bin/activate
echo "$PATH" >> $GITHUB_PATH
python3 -m pip install -r third_party/requirements.txt

- name: Configure CMake
run: >
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/reusable_docs_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ jobs:
sudo apt-get update
sudo apt-get install -y doxygen

- name: Install pip requirements
run: python3 -m pip install -r third_party/requirements.txt

- name: Setup PATH for python
run: echo "$HOME/.local/bin" >> $GITHUB_PATH
# Latest distros do not allow global pip installation
- name: Install Python requirements in venv
run: |
python3 -m venv .venv
. .venv/bin/activate
echo "$PATH" >> $GITHUB_PATH
python3 -m pip install -r third_party/requirements.txt

- name: Build the documentation
working-directory: scripts
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/reusable_qemu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,14 @@ jobs:
sudo apt-get update
sudo apt-get install -y qemu-system genisoimage qemu-utils \
libvirt-clients libvirt-daemon-system libvirt-daemon virtinst bridge-utils
pip install -r umf/scripts/qemu/requirements.txt

# Latest distros do not allow global pip installation
- name: Install Python requirements in venv
run: |
python3 -m venv .venv
. .venv/bin/activate
echo "$PATH" >> $GITHUB_PATH
python3 -m pip install -r umf/scripts/qemu/requirements.txt

- name: Add user to kvm group
run: sudo usermod -a -G kvm,libvirt $USER
Expand Down
Loading