-
Notifications
You must be signed in to change notification settings - Fork 42
[CI] New workflows order part1 #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] New workflows order part1 #791
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
3bbdcfe to
6864590
Compare
7178d9d to
17f8762
Compare
it's already covered in "Basic builds".
It seems Scorecard is accepting reusable workflows now. Verified on my fork where workflows works properly and there's no change in the Score.
17f8762 to
fde1ca7
Compare
Latest distros do not allow global pip installation. Python packages have to be installed in venv, on Linux. Signed-off-by: Lukasz Dorau <[email protected]>
fde1ca7 to
10b9391
Compare
|
Code coverage did not change - still 80,1% - sounds like I didn't break anything with this change :) |
| @@ -1,3 +1,4 @@ | |||
| # Run tests with valgrind intstrumentation tools: memcheck, drd, helgrind | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intstrumentation -> instrumentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix that in the next PR; I'd like to omit waiting for the whole CI to re-run 😄
Please review each commit separately. Verified on my fork it all works as expected.
Notes:
.github/workflowsdirectory.Checklist