Skip to content

[CI] New workflows order part1 #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2024
Merged

[CI] New workflows order part1 #791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b866b7c
[CI] Rename sub-workflows with "reusable_" prefix
lukaszstolarczuk Oct 9, 2024
59e9dfc
[CI] Merge spell check with code style check into a single job
lukaszstolarczuk Oct 9, 2024
e7c3317
[CI] Run all Valgrind tools in a single job
lukaszstolarczuk Oct 9, 2024
f65a78e
[CI] Remove flag check in Windows' "Fast builds"
lukaszstolarczuk Oct 9, 2024
2ad5ace
[CI] Do Bandit scan only on Linux and move it to 'checks' workflow
lukaszstolarczuk Oct 9, 2024
0e235a7
[CI] Move CodeQL and Trivy back into PR/Push workflow
lukaszstolarczuk Oct 9, 2024
10b9391
[CI] Fix all pip installations
ldorau Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/reusable_valgrind.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Run tests with valgrind intstrumentation tools: memcheck, drd, helgrind
Copy link
Contributor

@ldorau ldorau Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intstrumentation -> instrumentation

Copy link
Contributor Author

@lukaszstolarczuk lukaszstolarczuk Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that in the next PR; I'd like to omit waiting for the whole CI to re-run 😄

name: Valgrind

on: workflow_call
Expand All @@ -8,10 +9,6 @@ permissions:
jobs:
valgrind:
name: Valgrind
strategy:
fail-fast: false
matrix:
tool: ['memcheck', 'drd', 'helgrind']
runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -42,5 +39,11 @@ jobs:
- name: Build
run: cmake --build ${{github.workspace}}/build --config Debug -j$(nproc)

- name: Run tests under valgrind
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build ${{matrix.tool}}
- name: Run tests with 'memcheck'
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build memcheck

- name: Run tests with 'drd'
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build drd

- name: Run tests with 'helgrind'
run: ${{github.workspace}}/test/test_valgrind.sh ${{github.workspace}} ${{github.workspace}}/build helgrind
2 changes: 2 additions & 0 deletions test/test_valgrind.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ for test in $(ls -1 umf_test-*); do
fi || true
done

rm -rf ${BUILD_DIR}/test/cpuid

[ $ANY_TEST_FAILED -eq 0 ] && echo PASSED && exit 0

echo
Expand Down