Skip to content

Conversation

@aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 23, 2023

Also removes these checks from the cuda and hip adapters since they should be caught by the validation layer now.

The new validation rules bring image_desc_t in line with the CL struct it was derived from. We already had CTS coverage for them.

LLVM testing intel/llvm#12267

@aarongreig aarongreig requested review from a team as code owners November 23, 2023 17:28
@aarongreig
Copy link
Contributor Author

I want to remove the "must be zero" members from the struct, still looking into their original purpose so I can write up a proper issue about it.

@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:47
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

Also removes these checks from the cuda and hip adapters since they
should be caught by the validation layer now.

The new validation rules bring image_desc_t in line with the CL struct
it was derived from. We already had CTS coverage for them.
@aarongreig aarongreig force-pushed the aaron/validateImageDesc branch from b5dff26 to 42c60fa Compare December 28, 2023 15:32
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8d1486a) 15.74% compared to head (42c60fa) 15.73%.
Report is 18 commits behind head on main.

Files Patch % Lines
source/loader/layers/validation/ur_valddi.cpp 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   15.74%   15.73%   -0.01%     
==========================================
  Files         223      223              
  Lines       31466    31483      +17     
  Branches     3556     3561       +5     
==========================================
  Hits         4953     4953              
- Misses      26462    26480      +18     
+ Partials       51       50       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarongreig
Copy link
Contributor Author

@oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write the changes here are trivial but I don't really want to establish a precedent for merging stuff without code owner approval

@aarongreig aarongreig closed this Jan 9, 2024
@aarongreig
Copy link
Contributor Author

absorbed into #1212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants