Batch adapter changes: spec motivated refactors #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
- Coverage 15.44% 15.38% -0.07%
==========================================
Files 239 240 +1
Lines 33970 34135 +165
Branches 3758 3781 +23
==========================================
+ Hits 5246 5250 +4
- Misses 28673 28834 +161
Partials 51 51 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 9, 2024
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
from
5f073f3 to
e66d5bc
Compare
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
2 times, most recently
from
100798b to
16e8095
Compare
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
from
a7c04c0 to
43313b0
Compare
This was referenced Feb 9, 2024
kbenzie
added
loader
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
2 times, most recently
from
7e5fd51 to
69ddf01
Compare
github-actions
bot
added
the
command-buffer
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
3 times, most recently
from
9ead86f to
8089d80
Compare
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
from
8089d80 to
be51455
Compare
Contributor
Author
|
the e2e tests aren't going to work here since this requires a change on the LLVM side to build |
callumfare
approved these changes
Jun 26, 2024
hdelan
approved these changes
Jun 26, 2024
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
2 times, most recently
from
5749dea to
15b8ce2
Compare
github-actions
bot
added
the
sanitizer
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
from
15b8ce2 to
719e62d
Compare
Also removes these checks from the cuda and hip adapters since they should be caught by the validation layer now. The new validation rules bring image_desc_t in line with the CL struct it was derived from. We already had CTS coverage for them.
This brings it in line with OpenCL, and with SYCL's expectations. Addresses oneapi-src#1038
This gates support for the EnqueueDeviceGlobalVariableRead and Write operations. The CTS tests for these now check for support before running, and all adapters report their support correctly.
The native CPU adapter has been added to CI since some of these PRs were reviewed, so inevitably we need to tack some match file fixes on here post scriptum.
* Return UNSUPPORTED_ENUMERATION in device info query when FP16
extension isn't supported
* Add a mapping from CL_INVALID_ARG_SIZE to
UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE
* Remove a bunch of {{OPT}} entries from the enqueue match file, these
should all be passing since bounds checking was added to the
validation layer
* Write in a special case for PROGRAM_INFO_BINARIES test - this query
works pretty differently to the others
This lines up better with the original PI error code and what it was meant to convey. Also clarify the spec around return codes for urProgramGetFunctionPointer and update the relevant CTS test.
aarongreig
force-pushed
the
aaron/specMotivatedRefactors
branch
from
719e62d to
2f121cd
Compare
kbenzie
approved these changes
Jul 2, 2024
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 5, 2024
Pulls in changes from oneapi-src/unified-runtime#1212 --------- Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a batch PR containing a number of spec-motivated refactors/small changes. Changes include:
llvm testing intel/llvm#12681