Skip to content

Conversation

@aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Nov 27, 2023

LLVM testing intel/llvm#12268

@aarongreig aarongreig requested review from a team as code owners November 27, 2023 14:04
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:46
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@aarongreig aarongreig force-pushed the aaron/testKernelSetSpecQuery branch from e865a18 to 2a2227c Compare December 28, 2023 15:33
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d1486a) 15.74% compared to head (5231365) 15.72%.
Report is 18 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
- Coverage   15.74%   15.72%   -0.02%     
==========================================
  Files         223      223              
  Lines       31466    31475       +9     
  Branches     3556     3557       +1     
==========================================
- Hits         4953     4951       -2     
- Misses      26462    26473      +11     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM or level zero

@aarongreig aarongreig force-pushed the aaron/testKernelSetSpecQuery branch from 5231365 to a4b9724 Compare January 17, 2024 10:35
Copy link
Contributor

@omarahmed1111 omarahmed1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS info to Native CPU too.

@aarongreig aarongreig requested a review from a team as a code owner January 17, 2024 10:59
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

@aarongreig
Copy link
Contributor Author

absorbed into #1212

@aarongreig aarongreig closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants