Skip to content

Conversation

@aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Jan 2, 2024

  • Return UNSUPPORTED_ENUMERATION in device info query when FP16
    extension isn't supported
  • Add a mapping from CL_INVALID_ARG_SIZE to
    UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE
  • Remove a bunch of {{OPT}} entries from the enqueue match file, these
    should all be passing since bounds checking was added to the
    validation layer
  • Write in a special case for PROGRAM_INFO_BINARIES test - this query
    works pretty differently to the others

LLVM testing intel/llvm#12558

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (fb83446) 15.72% compared to head (12f47f9) 15.72%.

Files Patch % Lines
test/conformance/program/urProgramGetInfo.cpp 0.00% 18 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   15.72%   15.72%   -0.01%     
==========================================
  Files         223      223              
  Lines       31475    31487      +12     
  Branches     3557     3558       +1     
==========================================
+ Hits         4951     4952       +1     
- Misses      26473    26484      +11     
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarongreig aarongreig force-pushed the aaron/miscCLCtsFixes branch 2 times, most recently from a2174e3 to 12f47f9 Compare January 2, 2024 17:38
@aarongreig aarongreig marked this pull request as ready for review January 2, 2024 17:38
@aarongreig aarongreig requested review from a team as code owners January 2, 2024 17:38
* Return UNSUPPORTED_ENUMERATION in device info query when FP16
  extension isn't supported
* Add a mapping from CL_INVALID_ARG_SIZE to
  UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE
* Remove a bunch of {{OPT}} entries from the enqueue match file, these
  should all be passing since bounds checking was added to the
  validation layer
* Write in a special case for PROGRAM_INFO_BINARIES test - this query
  works pretty differently to the others
@aarongreig aarongreig force-pushed the aaron/miscCLCtsFixes branch from 12f47f9 to c47c39c Compare January 31, 2024 10:37
@aarongreig
Copy link
Contributor Author

merged into #1212

@aarongreig aarongreig closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants