-
Notifications
You must be signed in to change notification settings - Fork 124
Add a DeviceGetInfo test for DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a DeviceGetInfo test for DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS #1125
Conversation
|
I have updated the target branch of this PR from the |
e865a18 to
2a2227c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
- Coverage 15.74% 15.72% -0.02%
==========================================
Files 223 223
Lines 31466 31475 +9
Branches 3556 3557 +1
==========================================
- Hits 4953 4951 -2
- Misses 26462 26473 +11
Partials 51 51 ☔ View full report in Codecov by Sentry. |
2a2227c to
f6b524d
Compare
f6b524d to
5231365
Compare
nrspruit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM or level zero
5231365 to
a4b9724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could add UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS info to Native CPU too.
PietroGhg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU lgtm, thank you
|
absorbed into #1212 |
LLVM testing intel/llvm#12268