Skip to content

Remove redundant file sorting in FoldersController #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

Remove redundant file sorting in FoldersController #477

merged 1 commit into from
Oct 17, 2025
+2 −2

Conversation

arukompas
Copy link
Contributor

Summary

  • Replaced sortByEarliestFirstIncludingFiles() with sortByEarliestFirst()
  • Replaced sortByLatestFirstIncludingFiles() with sortByLatestFirst()
  • File sorting is already handled by the loop on lines 41-56, making the IncludingFiles methods redundant

Test plan

  • All 273 tests pass
  • Feature tests verify folder and file sorting behavior remains unchanged

@arukompas arukompas self-assigned this Oct 17, 2025
@arukompas arukompas mentioned this pull request Oct 17, 2025
Merged
@arukompas arukompas merged commit 011c3cd into main Oct 17, 2025
26 checks passed
@arukompas arukompas deleted the refactor/remove-redundant-file-sorting branch October 18, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arukompas arukompas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arukompas