Skip to content

Fix assert_operation_response/2 references #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zorbash merged 2 commits into from
Jul 8, 2025
Merged

Fix assert_operation_response/2 references #673

zorbash merged 2 commits into from
Jul 8, 2025

Conversation

@zorbash
Copy link
Contributor

@zorbash zorbash commented Jul 8, 2025

Previously a reference response would lead to the following error.

     Failed to resolve a response schema for operation_id: some_operation_id for status code: 404 and content type: application/json

This was caused by assert_operation_response/2 not resolving references.

@zorbash zorbash changed the title Assert operation response ref Fix assert_operation_response/2 references Jul 8, 2025
msutkowski
msutkowski approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@msutkowski msutkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I did this, but woo! Nice work.

@zorbash zorbash merged commit c71c312 into master Jul 8, 2025
9 checks passed
@zorbash zorbash deleted the assert-operation-response-ref branch July 8, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msutkowski msutkowski msutkowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zorbash @msutkowski