Skip to content

Fix assert_operation_response/2 references #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zorbash merged 2 commits into from
Jul 8, 2025
Merged

Fix assert_operation_response/2 references #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95bef39
Support references in assert_operation_response/2
zorbash Jul 8, 2025
2c16780
fixup! Support references in assert_operation_response/2
zorbash Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/open_api_spex/test/test_assertions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,17 @@ defmodule OpenApiSpex.TestAssertions do
Map.get(responses, code_range) ||
Map.get(responses, :"#{code_range}", %{})

resolved_response =
case response do
%OpenApiSpex.Reference{} = ref ->
OpenApiSpex.Reference.resolve_response(ref, spec.components.responses)

_ ->
response
end

resolved_schema =
response
resolved_response
|> Map.get(:content, %{})
|> Map.get(content_type, %{})
|> Map.get(:schema)
Expand Down
2 changes: 1 addition & 1 deletion test/support/api_spec.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ defmodule OpenApiSpexTest.ApiSpec do
}
},
responses: %{
unprocessable_entity: %Response{
"unprocessable_entity" => %Response{
description: "Unprocessable Entity",
content: %{"application/json" => %MediaType{schema: %Schema{type: :object}}}
}
Expand Down
4 changes: 3 additions & 1 deletion test/support/pet_controller.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ defmodule OpenApiSpexTest.PetController do
],
responses: [
ok: {"Pet list", "application/json", Schemas.PetsResponse},
unprocessable_entity: OpenApiSpex.JsonErrorResponse.response()
unprocessable_entity: %OpenApiSpex.Reference{
"$ref": "#/components/responses/unprocessable_entity"
}
],
operation_id: "listPets"
def index(conn, _params) do
Expand Down
Loading