Skip to content

[Refactor] Code refactoarization#1831

Merged
MaiziXiao merged 5 commits intoopen-compass:mainfrom
MaiziXiao:oc_0_4_0_dev
Jan 20, 2025
Merged

[Refactor] Code refactoarization#1831
MaiziXiao merged 5 commits intoopen-compass:mainfrom
MaiziXiao:oc_0_4_0_dev

Conversation

@MaiziXiao
Copy link
Contributor

@MaiziXiao MaiziXiao commented Jan 17, 2025 •
edited
Loading

  1. Remove root folder configs
  2. Update pre-commit config
  3. Refactor Openai model class
  4. Remove EOS token id from vLLM class

@MaiziXiao MaiziXiao requested a review from tonysy January 17, 2025 02:21
tonysy
tonysy approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaiziXiao MaiziXiao merged commit a6193b4 into open-compass:main Jan 20, 2025
8 checks passed
@MaiziXiao MaiziXiao mentioned this pull request Jan 20, 2025
Closed
6 tasks
stephen-nju pushed a commit to stephen-nju/opencompass that referenced this pull request May 14, 2025
@MaiziXiao
[Refactor] Code refactoarization (open-compass#1831)
52106eb 
* Update

* fix lint

* update

* fix lint
zyc140345 pushed a commit to zyc140345/opencompass that referenced this pull request Oct 23, 2025
@MaiziXiao
[Refactor] Code refactoarization (open-compass#1831)
a585568 
* Update

* fix lint

* update

* fix lint
iamkaia pushed a commit to iamkaia/opencompass that referenced this pull request Feb 4, 2026
@MaiziXiao
[Refactor] Code refactoarization (open-compass#1831)
ba2473d 
* Update

* fix lint

* update

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonysy tonysy tonysy approved these changes

Assignees

@tonysy tonysy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaiziXiao @tonysy