Skip to content

Add efibootmgr and unify EFI boot entry handling#129

Merged
anujm1 merged 1 commit intoopen-edge-platform:3.0-devfrom
Jkintalix:efibootentry-enhancement
May 30, 2025
Merged

Add efibootmgr and unify EFI boot entry handling#129
anujm1 merged 1 commit intoopen-edge-platform:3.0-devfrom
Jkintalix:efibootentry-enhancement

Conversation

@Jkintalix
Copy link
Copy Markdown
Contributor

@Jkintalix Jkintalix commented May 23, 2025

  • Added efibootmgr to core-packages-image.json package list
  • Enhanced boot entry creation for both attended and Kickstart-based installs
  • Updated boot label to Edge MicrovisorToolkit
  • Improved EFI entry cleanup logic for existing boot entries

Merge Checklist

All boxes should be checked before merging the PR

  • The changes in the PR have been built and tested
  • [] cgmanifest file has been updated if required
  • Ready to merge

Description

Adds efibootmgr and improves EFI boot entry creation for both attended and Kickstart-based installs.
Updates boot label and cleanup logic to ensure consistent setup across install modes.

Any Newly Introduced Dependencies

None

How Has This Been Tested?

verified manually in all core platforms

@Jkintalix Jkintalix requested a review from a team as a code owner May 23, 2025 07:05
@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch 4 times, most recently from d132832 to 2d6206c Compare May 23, 2025 16:26
@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch from 2d6206c to 76dea15 Compare May 28, 2025 08:25
@Jkintalix Jkintalix requested a review from a team as a code owner May 28, 2025 08:32
@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch 2 times, most recently from 5805b98 to f18992a Compare May 28, 2025 09:18
@Jkintalix Jkintalix requested review from anujm1 and yepmunchun May 28, 2025 09:55
@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch 2 times, most recently from 2be6ce5 to b4eb9c6 Compare May 28, 2025 12:05
@yepmunchun
Copy link
Copy Markdown
Contributor

yepmunchun commented May 29, 2025

Consider not logging raw output at INFO level if it could be large or noisy, DEBUG level might be more appropriate.

Please cleanup logging:
If it is not needed, remove it
If it is low level info, move it to DEBUG level
Leave only informational type to INFO level

@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch 3 times, most recently from 3553f24 to 7629dec Compare May 29, 2025 09:48
@Jkintalix Jkintalix requested a review from yepmunchun May 29, 2025 09:54
@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch 4 times, most recently from f8ba405 to 171b3e5 Compare May 30, 2025 05:13
- Added efibootmgr to grub2-mkconfig package list
- Enhanced boot entry creation for both attended and Kickstart-based installs
- Updated boot label to Edge MicrovisorToolkit
- Improved EFI entry cleanup logic for existing boot entries

Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>
@Jkintalix Jkintalix force-pushed the efibootentry-enhancement branch from 171b3e5 to 83a3dc1 Compare May 30, 2025 05:15
@anujm1 anujm1 merged commit 9416998 into open-edge-platform:3.0-dev May 30, 2025
7 checks passed
ranjan-dutta pushed a commit that referenced this pull request Jun 26, 2025
- Added efibootmgr to grub2-mkconfig package list
- Enhanced boot entry creation for both attended and Kickstart-based installs
- Updated boot label to Edge MicrovisorToolkit
- Improved EFI entry cleanup logic for existing boot entries

Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants