CPP Refactor - Instantiate all tasks with user config and replicate old api #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use old create_model so that api doesn't change.
github-actions
bot
added
tests
RHeckerIntel
changed the title
Also fix the way the model loads Preload is basically calling the compileModel so dont pass it in initially unless we're sure that it doesnt need transforming
Missing serialization. Need to allow for that again.
RHeckerIntel
force-pushed
the
rhecker/cpp-refactor-load-cleanup
branch
from
25927d9 to
fbf8250
Compare
sovrasov
reviewed
Jul 1, 2025
sovrasov
reviewed
Jul 1, 2025
sovrasov
reviewed
Jul 2, 2025
sovrasov
approved these changes
Jul 2, 2025
sovrasov
merged commit ddda762
into
open-edge-platform:feature/cpp_refactoring
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiate the models with config: Closes #300
No strong favor for create_model or load. So lets reduce pain for the users and just replicate old api.