fix(deps): move to io.opentelemetry.semconv:opentelemetry-semconv #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Kavindu-Dodan,
beeme1mr,
thiyagu06 and
toddbaert
Mahoney
changed the title
Mahoney
force-pushed
the
fix-otel-deps
branch
from
2482d51 to
4e4f1e7
Compare
[`io.opentelemetry:opentelemetry-semconv`](https://search.maven.org/artifact/io.opentelemetry/opentelemetry-semconv) was moved to [`io.opentelemetry.semconv:opentelemetry-semconv`](https://search.maven.org/artifact/io.opentelemetry.semconv/opentelemetry-semconv) and the former [will be deprecated](open-telemetry/opentelemetry-java#5786). Signed-off-by: Robert Elliot <[email protected]>
Mahoney
force-pushed
the
fix-otel-deps
branch
from
4e4f1e7 to
562d3f2
Compare
aepfli
approved these changes
Oct 24, 2024
Member
aepfli
left a comment
aepfli
left a comment
There was a problem hiding this comment.
just checking for safety, if this version downgrade can have any bigger impact ;) - but generally this looks good to me
Contributor
Author
|
It's not a version downgrade, though it looks like it. They have brought their versioning in line with the spec, and If you check search.maven.org, io.opentelemetry:opentelemetry-semconv:1.30.1-alpha (the replaced version) was released on 2023-09-11, whereas io.opentelemetry.semconv:opentelemetry-semconv was released on 2024-10-15. |
beeme1mr
approved these changes
Oct 31, 2024
beeme1mr
approved these changes
Oct 31, 2024
Member
|
Greetings @Mahoney, could you please update this branch? I've set the PR to auto-merge once it's up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.opentelemetry:opentelemetry-semconvwas moved toio.opentelemetry.semconv:opentelemetry-semconvand the former will be deprecated.