Skip to content

fix(deps): move to io.opentelemetry.semconv:opentelemetry-semconv #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix(deps): move to io.opentelemetry.semconv:opentelemetry-semconv #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
562d3f2
fix(deps): move to io.opentelemetry.semconv:opentelemetry-semconv
Mahoney Oct 24, 2024
ea76a2e
Merge branch 'main' into fix-otel-deps
Mahoney Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .sdkmanrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
java=8.0.312-tem
6 changes: 3 additions & 3 deletions hooks/open-telemetry/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@

<dependencies>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>1.30.1-alpha</version>
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv-incubating</artifactId>
<version>1.28.0-alpha</version>
</dependency>

<dependency>
Expand Down
11 changes: 7 additions & 4 deletions hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OTelCommons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
package dev.openfeature.contrib.hooks.otel;

import io.opentelemetry.api.common.AttributeKey;
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;

import static io.opentelemetry.semconv.incubating.FeatureFlagIncubatingAttributes.FEATURE_FLAG_KEY;
import static io.opentelemetry.semconv.incubating.FeatureFlagIncubatingAttributes.FEATURE_FLAG_PROVIDER_NAME;
import static io.opentelemetry.semconv.incubating.FeatureFlagIncubatingAttributes.FEATURE_FLAG_VARIANT;

class OTelCommons {
// Define semantic conventions
// Refer - https://opentelemetry.io/docs/specs/otel/logs/semantic_conventions/feature-flags/
static final String EVENT_NAME = "feature_flag";

static final AttributeKey<String> flagKeyAttributeKey = SemanticAttributes.FEATURE_FLAG_KEY;
static final AttributeKey<String> providerNameAttributeKey = SemanticAttributes.FEATURE_FLAG_PROVIDER_NAME;
static final AttributeKey<String> variantAttributeKey = SemanticAttributes.FEATURE_FLAG_VARIANT;
static final AttributeKey<String> flagKeyAttributeKey = FEATURE_FLAG_KEY;
static final AttributeKey<String> providerNameAttributeKey = FEATURE_FLAG_PROVIDER_NAME;
static final AttributeKey<String> variantAttributeKey = FEATURE_FLAG_VARIANT;

// Define non convention attribute keys
static final String REASON_KEY = "reason";
Expand Down