feat(ofrep): adding error details for 401, 403 and 429 #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
beeme1mr
approved these changes
Aug 1, 2025
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
I left a comment about an alternative approach but I'm fine with this too. Thanks!
Signed-off-by: Thomas Poignant <[email protected]>
Member
Author
|
Good catch @beeme1mr I've move it to the exception directly. |
lukas-reining
approved these changes
Aug 5, 2025
thomaspoignant
added a commit
that referenced
this pull request
Nov 19, 2025
Signed-off-by: Thomas Poignant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Current implementation does not include any error details when failing in 401, 403 or 429.