Skip to content

feat(ofrep): adding error details for 401, 403 and 429 #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaspoignant merged 2 commits into from
Aug 5, 2025
Merged

feat(ofrep): adding error details for 401, 403 and 429 #1361

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
964070d
feat(ofrep): adding error details for 401, 403 and 429
thomaspoignant Aug 1, 2025
c2fc413
move error into the exception itself
thomaspoignant Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/shared/ofrep-core/src/lib/api/ofrep-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ export class OFREPApi {
}

if (response.status === 401) {
throw new OFREPApiUnauthorizedError(response);
throw new OFREPApiUnauthorizedError(response, 'OFREP request failed: unauthorized');
}

if (response.status === 403) {
throw new OFREPForbiddenError(response);
throw new OFREPForbiddenError(response, 'OFREP request failed: forbidden');
}

if (response.status === 429) {
throw new OFREPApiTooManyRequestsError(response);
throw new OFREPApiTooManyRequestsError(response, 'OFREP request failed: too many requests');
}

if (response.status === 200 && !this.isJsonMime(response)) {
Expand Down