Skip to content

Conversation

@uthark
Copy link
Contributor

@uthark uthark commented Jun 3, 2025

This PR

Allow to configure GCS buckets.

Tested locally, confirmed that flagd deployment is created and that deployment can pull the data (tested on GKE with Workload identity support enabled)

  • adds this new feature

Related Issues

Relates to #758

Notes

Follow-up Tasks

How to test

configured feature source to use gs buckets:

  spec:
    sources:
    - interval: 15
      provider: gcs
      source: gs://my-bucket/test.json

Signed-off-by: Oleg Atamanenko <[email protected]>
@uthark uthark requested a review from a team June 3, 2025 05:15
@uthark
Copy link
Contributor Author

uthark commented Jun 3, 2025

@beeme1mr could you please have a look?

@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.55%. Comparing base (499661e) to head (abde60d).
Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
internal/common/flagdinjector/flagdinjector.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #765       +/-   ##
===========================================
- Coverage   86.51%   71.55%   -14.97%     
===========================================
  Files          19       30       +11     
  Lines        1587     2299      +712     
===========================================
+ Hits         1373     1645      +272     
- Misses        173      606      +433     
- Partials       41       48        +7     
Files with missing lines Coverage Δ
api/core/v1beta1/common/common.go 82.97% <100.00%> (ø)
internal/common/flagdinjector/flagdinjector.go 90.21% <0.00%> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
unit-tests 71.55% <20.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@uthark
Copy link
Contributor Author

uthark commented Jun 3, 2025

@beeme1mr should I try to write tests?

@toddbaert
Copy link
Member

@beeme1mr should I try to write tests?

No I think this is minimal enough not to require them. I can override the check.

@toddbaert toddbaert added this pull request to the merge queue Jun 3, 2025
Merged via the queue into open-feature:main with commit 349c176 Jun 3, 2025
17 of 19 checks passed
@uthark uthark deleted the o/gcs-support branch June 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants