-
Notifications
You must be signed in to change notification settings - Fork 47
feat(flagd): add support for azure blob #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix for EnvVarKey function to prevent corrupting Azure related env vars keys Signed-off-by: vmai <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
===========================================
- Coverage 86.51% 71.25% -15.26%
===========================================
Files 19 30 +11
Lines 1587 2324 +737
===========================================
+ Hits 1373 1656 +283
- Misses 173 620 +447
- Partials 41 48 +7
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@beeme1mr could you please have a look? |
beeme1mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for the delayed approval. I had some feedback on the env changes but everything else looks good.
- fix for ToEnvVars function to not add prefix for Azure blob related env vars Signed-off-by: vmai <[email protected]>
lukas-reining
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @VMaievskyi!
This PR
Allow to configure Azure Blob as source for config
Verified that Flagd sidecar is created and connected to Azure Blob (SAS Key used for access)
Related Issues
Relates to:
#765
#758
Notes
At current moment it can work only with FeatureFlagSource.envVarPrefix = "" and spec.sidecarConfiguration: ""
as prefix breaks env var name and flagd cannot find mandatory env variables.
Follow-up Tasks
Fix flagd to search for Azure blob env vars ignoring prefix.
How to test
Works with end-to-end.yaml