Skip to content

Conversation

@VMaievskyi
Copy link
Contributor

@VMaievskyi VMaievskyi commented Aug 20, 2025

This PR

Allow to configure Azure Blob as source for config
Verified that Flagd sidecar is created and connected to Azure Blob (SAS Key used for access)

Related Issues

Relates to:
#765
#758

Notes

At current moment it can work only with FeatureFlagSource.envVarPrefix = "" and spec.sidecarConfiguration: ""
as prefix breaks env var name and flagd cannot find mandatory env variables.

Follow-up Tasks

Fix flagd to search for Azure blob env vars ignoring prefix.

How to test

Works with end-to-end.yaml

apiVersion: core.openfeature.dev/v1beta1
kind: FeatureFlagSource
metadata:
  name: end-to-end
  namespace: open-feature-demo
spec:
  sources:
  - source: azblob://my-bucket/test.json
    provider: azblob
  envVarPrefix: ""
  envVars:
  - name: AZURE_STORAGE_ACCOUNT
    value: <account_name>
  - name: AZURE_STORAGE_SAS_TOKEN
    value: <SAS token>

 - fix for EnvVarKey function to prevent corrupting Azure related env vars keys

Signed-off-by: vmai <[email protected]>
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.25%. Comparing base (499661e) to head (7ee876d).
⚠️ Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
internal/common/flagdinjector/flagdinjector.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #779       +/-   ##
===========================================
- Coverage   86.51%   71.25%   -15.26%     
===========================================
  Files          19       30       +11     
  Lines        1587     2324      +737     
===========================================
+ Hits         1373     1656      +283     
- Misses        173      620      +447     
- Partials       41       48        +7     
Files with missing lines Coverage Δ
api/core/v1beta1/common/common.go 84.90% <100.00%> (ø)
api/core/v1beta1/featureflagsource_types.go 96.90% <100.00%> (ø)
internal/common/flagdinjector/flagdinjector.go 88.29% <0.00%> (ø)

... and 11 files with indirect coverage changes

Flag Coverage Δ
unit-tests 71.25% <60.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VMaievskyi VMaievskyi marked this pull request as ready for review August 21, 2025 19:29
@VMaievskyi
Copy link
Contributor Author

@beeme1mr could you please have a look?

@beeme1mr beeme1mr self-requested a review September 8, 2025 14:50
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delayed approval. I had some feedback on the env changes but everything else looks good.

 - fix for ToEnvVars function to not add prefix for Azure blob related env vars

Signed-off-by: vmai <[email protected]>
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @VMaievskyi!

@lukas-reining lukas-reining merged commit 0d505d0 into open-feature:main Oct 5, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants