-
Notifications
You must be signed in to change notification settings - Fork 23
build(flagd): auto generate proto files from schema #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Simon Schrottner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about some tradeoffs I made - I hope this helps; my reviews are still not the most valuable, especially with the build toolchain. - and I am fine if this supersedes my pr. I just want to get this sdk forward and a little bit more in sync with the java version feature wise
after doing this change I now remember why we have the shell script, I sadly have to revert this part. The big problem is we need the generated protobuf files inside the provider namespace, otherwise thet dangle somewhere outside and can conflict with any package just named |
|
with this commit, i changed the generator to mypy-protobuf - which allowed my to specify a proper path without issues, and custom manipulation of the protobuf files |
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: gruebel <[email protected]>
5f390d0 to
214b119
Compare
Signed-off-by: gruebel <[email protected]>
214b119 to
8942418
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 90.55% 95.03% +4.47%
==========================================
Files 8 13 +5
Lines 180 483 +303
==========================================
+ Hits 163 459 +296
- Misses 17 24 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks! |
This PR