-
Notifications
You must be signed in to change notification settings - Fork 23
build(flagd): auto generate proto files from schema #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(flagd): auto generate proto files from schema #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 90.55% 95.21% +4.66%
==========================================
Files 8 13 +5
Lines 180 481 +301
==========================================
+ Hits 163 458 +295
- Misses 17 23 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Simon Schrottner <[email protected]>
a900822 to
3477153
Compare
gruebel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🍻
I'm actually not so worried about the plugin being new or will become unmaintained over time. I checked the code and worst case we can just copy it over or maintain our own fork of it.
Did you test the wheel creation and made sure the generated files are included?
As I am lacking a little bit of insight/terminology. I write what I did and what I saw afterward ;) and what i interpret into it. I ran //EDIT: added #112 for handling the dist files |
3e506c2 to
9b65323
Compare
|
This is still not ideal, but the proto files are now within a directory called flags within the src folder. As
|
5767066 to
3bfe42f
Compare
Signed-off-by: Simon Schrottner <[email protected]>
3bfe42f to
4b74a53
Compare
providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/grpc.py
Show resolved
Hide resolved
|
ok, I updated my previous PR #115 with @aepfli new changes and now it works without needing the Either you can pull my changes into your branch or we merge my fyi, nice workaround with moving the schemas to an |
|
Implemented via #115 |

autogenerating protobuf files is crucial - hence that, i applied a hatch plugin to build them automatically
The downside is, that this plugin is fairly new https://github.com/nanoporetech/hatch-protobuf - but from my check it currently looks safe to be used.
What happened in this PR:
hatch run testit is nowhatch testorhatch test -cif you want coveragehatch buildfirst - i am investigating how to best solve this see Running hook before `hatch test` pypa/hatch#1824