Skip to content

Conversation

@aepfli
Copy link
Member

@aepfli aepfli commented Dec 17, 2024

No description provided.

@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (41d0ad8) to head (c87fd7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          14       14           
  Lines         731      731           
=======================================
  Hits          689      689           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the failing tests related to the upgrade to version 0.5.18?

Signed-off-by: Simon Schrottner <[email protected]>
@aepfli
Copy link
Member Author

aepfli commented Dec 18, 2024

are the failing tests related to the upgrade to version 0.5.18?

It seems like there is something flaky here. I'll check, but I am already working on a different approach for tests with an unstable connection. We don't need an image that is regularly disconnecting, as we're using test containers; we can just kill the container and be faster with our tests. Additionally this should grant us more stability in the tests, as we're in control

@gruebel gruebel merged commit 3c3e9c8 into open-feature:main Dec 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants