Skip to content

feat(flagd): use test-harness version number for integration tests #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat(flagd): use test-harness version number for integration tests #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18dd5cd
feat(flagd): use test-harness version number for integration tests
aepfli Dec 17, 2024
c87fd7a
fixup: migrating to pathlib
aepfli Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
[submodule "providers/openfeature-provider-flagd/test-harness"]
path = providers/openfeature-provider-flagd/openfeature/test-harness
url = [email protected]:open-feature/flagd-testbed.git
branch = v0.5.18
[submodule "providers/openfeature-provider-flagd/spec"]
path = providers/openfeature-provider-flagd/openfeature/spec
url = https://github.com/open-feature/spec
2 changes: 1 addition & 1 deletion providers/openfeature-provider-flagd/openfeature/test-harness
Open in desktop
Submodule test-harness updated 4 files
+1 −1 .release-please-manifest.json
+7 −0 CHANGELOG.md
+1 −1 release-please-config.json
+1 −0 version.txt
7 changes: 5 additions & 2 deletions providers/openfeature-provider-flagd/tests/e2e/flagd_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import time
from pathlib import Path

import grpc
from grpc_health.v1 import health_pb2, health_pb2_grpc
Expand All @@ -11,11 +12,13 @@
class FlagdContainer(DockerContainer):
def __init__(
self,
image: str = "ghcr.io/open-feature/flagd-testbed:v0.5.15",
image: str = "ghcr.io/open-feature/flagd-testbed",
port: int = 8013,
**kwargs,
) -> None:
super().__init__(image, **kwargs)
path = Path(__file__).parents[2] / "openfeature/test-harness/version.txt"
data = path.read_text().rstrip()
super().__init__(f"{image}:v{data}", **kwargs)
self.port = port
self.with_exposed_ports(self.port, HEALTH_CHECK)

Expand Down
2 changes: 1 addition & 1 deletion providers/openfeature-provider-flagd/tests/e2e/test_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def port():

@pytest.fixture(autouse=True, scope="module")
def image():
return "ghcr.io/open-feature/flagd-testbed:v0.5.13"
return "ghcr.io/open-feature/flagd-testbed"


scenarios(
Expand Down
2 changes: 1 addition & 1 deletion providers/openfeature-provider-flagd/tests/e2e/test_rpc_reconnect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def port():

@pytest.fixture(autouse=True, scope="module")
def image():
return "ghcr.io/open-feature/flagd-testbed-unstable:v0.5.13"
return "ghcr.io/open-feature/flagd-testbed-unstable"


scenarios(
Expand Down
Loading