Issue1389 detailed house#1404
Conversation
|
@LoneMeertens, thank you for addressing the issue! I really like the new structure, a great improvement. :-) Also, adding more documentation/explanation provides significant added value.
|
|
@lucasverleyen Thank you for the detailed feedback and suggestions! 😊 I'm glad you like the new structure and the additional documentation. I’ll take this up and include open-ideas/CrashCourse#25 and Update Tutorial IDEAS #1374 in this PR as suggested—it does make sense to consolidate related issues and PRs. Regarding the documentation and result visualization, I'll align it with the SimpleHouse tutorial from IBPSA to ensure consistency and maintain the high standard of quality. I'll also add DetailedHouse10 (as DetailedHouse) as a final example, positioned at the same level as SimpleHouse. Thanks again for the valuable input! |
|
@LoneMeertens perfect! Thanks a lot! In the mean time, I have looked at the unit tests, but currently, I am not able to solve the issues. DetailedHouse5 does work, but the other examples do not and I don't know why... to be continued in the new year ;-) |
|
@jelgerjansen good catch (__Dymola_Commands)! I suggest adding this to the documentation of the testing framework: https://github.com/open-ideas/IDEAS/blob/master/IDEAS/Resources/Scripts/tests/README.md under Developing new tests. Something like: "Make sure that the file name and path in the model annotation under __Dymola_Comands correspond to the name and path to the .mos file in Resources/Scripts/Dymola/... " What do you think? |
There was a problem hiding this comment.
@LoneMeertens thank you for addressing this issue. Most comments are related to model documentation and syntax.
The models previously didn't run due to the reference to an unexisting mos file in __Dymola_Commands(). This does not generates warnings when translating the model in Dymola, but it does for the unit tests. I solved this issue via commits 8cca500 and e8f49c5
Once you've also addressed the other related issues (e.g. #1374), I'll do another review.
@lucasverleyen the If you add it, the file in |
…ating system as well.
…led house 1-5 models
- new name zon
lucasverleyen
left a comment
There was a problem hiding this comment.
@annadellisola thanks a lot for finalising this issue. Looks great! I only have some textual remarks. Once the new reference results are generated, fine for me to merge :-)
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
Co-authored-by: Lucas Verleyen <48284460+lucasverleyen@users.noreply.github.com>
…tens/IDEAS into issue1389_DetailedHouse
There was a problem hiding this comment.
Increase of "number of continuous time states" due to the use of two different components for ceiling and SlabOnGround, and the change from IDEAS.Buildings.Validation.Data.Constructions.HeavyFloor to IDEAS.Buildings.Data.Constructions.FloorOnGround.
| Update Ref Results | Old Reference Results |
|---|---|
| cei.layMul.monLay[1].monLayDyn.T[1] cei.layMul.monLay[1].monLayDyn.T[2] cei.layMul.monLay[2].monLayDyn.T[1] cei.layMul.monLay[3].monLayDyn.T[1] outWalEas.layMul.monLay[1].monLayDyn.T[1] outWalEas.layMul.monLay[1].monLayDyn.T[2] outWalEas.layMul.monLay[2].monLayDyn.T[1] outWalEas.layMul.monLay[3].monLayDyn.T[1] outWalEas.layMul.monLay[3].monLayDyn.T[2] outWalNor.layMul.monLay[1].monLayDyn.T[1] outWalNor.layMul.monLay[1].monLayDyn.T[2] outWalNor.layMul.monLay[2].monLayDyn.T[1] outWalNor.layMul.monLay[3].monLayDyn.T[1] outWalNor.layMul.monLay[3].monLayDyn.T[2] outWalSou.layMul.monLay[1].monLayDyn.T[1] outWalSou.layMul.monLay[1].monLayDyn.T[2] outWalSou.layMul.monLay[2].monLayDyn.T[1] outWalSou.layMul.monLay[3].monLayDyn.T[1] outWalSou.layMul.monLay[3].monLayDyn.T[2] outWalWes.layMul.monLay[1].monLayDyn.T[1] outWalWes.layMul.monLay[1].monLayDyn.T[2] outWalWes.layMul.monLay[2].monLayDyn.T[1] outWalWes.layMul.monLay[3].monLayDyn.T[1] outWalWes.layMul.monLay[3].monLayDyn.T[2] slaOnGro.layGro.monLay[1].monLayDyn.T[1] slaOnGro.layGro.monLay[1].monLayDyn.T[2] slaOnGro.layGro.monLay[1].monLayDyn.T[3] slaOnGro.layGro.monLay[1].monLayDyn.T[4] slaOnGro.layGro.monLay[1].monLayDyn.T[5] slaOnGro.layGro.monLay[1].monLayDyn.T[6] slaOnGro.layGro.monLay[1].monLayDyn.T[7] slaOnGro.layGro.monLay[2].monLayDyn.T[1] slaOnGro.layGro.monLay[2].monLayDyn.T[2] slaOnGro.layGro.monLay[2].monLayDyn.T[3] slaOnGro.layGro.monLay[2].monLayDyn.T[4] slaOnGro.layGro.monLay[3].monLayDyn.T[2] slaOnGro.layMul.monLay[1].monLayDyn.T[1] slaOnGro.layMul.monLay[1].monLayDyn.T[2] slaOnGro.layMul.monLay[1].monLayDyn.T[3] slaOnGro.layMul.monLay[1].monLayDyn.T[4] slaOnGro.layMul.monLay[2].monLayDyn.T[1] slaOnGro.layMul.monLay[3].monLayDyn.T[1] slaOnGro.layMul.monLay[4].monLayDyn.T[1] win.heaCapGlaExt.T win.heaCapGlaInt.T zon.airModel.vol.dynBal.m zon.airModel.vol.dynBal.medium.Xi[1] zon.airModel.vol.dynBal.U | floor.layMul.monLay[1].monLayDyn.T[1] floor.layMul.monLay[1].monLayDyn.T[2] floor.layMul.monLay[2].monLayDyn.T[1] outerWall.layMul.monLay[1].monLayDyn.T[1] outerWall.layMul.monLay[1].monLayDyn.T[2] outerWall.layMul.monLay[2].monLayDyn.T[1] outerWall.layMul.monLay[3].monLayDyn.T[1] outerWall.layMul.monLay[3].monLayDyn.T[2] outerWall1.layMul.monLay[1].monLayDyn.T[1] outerWall1.layMul.monLay[1].monLayDyn.T[2] outerWall1.layMul.monLay[2].monLayDyn.T[1] outerWall1.layMul.monLay[3].monLayDyn.T[1] outerWall1.layMul.monLay[3].monLayDyn.T[2] outerWall2.layMul.monLay[1].monLayDyn.T[1] outerWall2.layMul.monLay[1].monLayDyn.T[2] outerWall2.layMul.monLay[2].monLayDyn.T[1] outerWall2.layMul.monLay[3].monLayDyn.T[1] outerWall2.layMul.monLay[3].monLayDyn.T[2] outerWall3.layMul.monLay[1].monLayDyn.T[1] outerWall3.layMul.monLay[1].monLayDyn.T[2] outerWall3.layMul.monLay[2].monLayDyn.T[1] outerWall3.layMul.monLay[3].monLayDyn.T[1] outerWall3.layMul.monLay[3].monLayDyn.T[2] window.heaCapGlaExt.T window.heaCapGlaInt.T zone.airModel.vol.dynBal.m zone.airModel.vol.dynBal.medium.Xi[1] zone.airModel.vol.dynBal.U |
The figure below shows the difference in the reference variables:

Ref_res: InternalWall for ceiling and floor with highly insulated BESTEST heavy wall as construction type
Test: distinct SlabOnGround with FloorOnGround construction type, and ceiling lead to higher heat losses
There was a problem hiding this comment.
Increase of "number of continuous time states" due to the use of two different components for ceiling and SlabOnGround, and the change from IDEAS.Buildings.Validation.Data.Constructions.HeavyFloor to IDEAS.Buildings.Data.Constructions.FloorOnGround in both zones.
The figure below shows the change in reference variables:

Ref_res: InternalWall for ceiling and floor with highly insulated BESTEST heavy wall as construction type in both zones
Test: distinct SlabOnGround with FloorOnGround construction type, and ceiling lead to higher heat losses. The error in recZon1, with a south-oriented window is higher.
There was a problem hiding this comment.
Increase of "number of continuous time states" due to the use of two different components for ceiling and SlabOnGround, the change from IDEAS.Buildings.Validation.Data.Constructions.HeavyFloor to IDEAS.Buildings.Data.Constructions.FloorOnGround in both zones and the addition of pumEmi:
| Update Ref Results | Old Reference Results |
|---|---|
| EEl.y heaPum.con.vol.dynBal.U heaPum.eva.vol.dynBal.U pumEmi.motSpe.y pumEmi.vol.dynBal.U pumPri.motSpe.y pumPri.vol.dynBal.U pumSec.motSpe.y pumSec.vol.dynBal.U rad.vol[1].dynBal.U rad.vol[2].dynBal.U rad.vol[3].dynBal.U rad.vol[4].dynBal.U rad.vol[5].dynBal.U rad1.vol[1].dynBal.U rad1.vol[2].dynBal.U rad1.vol[3].dynBal.U rad1.vol[4].dynBal.U rad1.vol[5].dynBal.U rectangularZoneTemplate.airModel.vol.dynBal.m rectangularZoneTemplate.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate.airModel.vol.dynBal.U rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.intC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outCei.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outCei.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outCei.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outCei.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[3] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[4] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[5] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[6] rectangularZoneTemplate.slaOnGro.layGro.monLay[1].monLayDyn.T[7] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[3] rectangularZoneTemplate.slaOnGro.layGro.monLay[2].monLayDyn.T[4] rectangularZoneTemplate.slaOnGro.layGro.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[3] rectangularZoneTemplate.slaOnGro.layMul.monLay[1].monLayDyn.T[4] rectangularZoneTemplate.slaOnGro.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.slaOnGro.layMul.monLay[4].monLayDyn.T[1] rectangularZoneTemplate.winA.heaCapGlaExt.T rectangularZoneTemplate.winA.heaCapGlaInt.T rectangularZoneTemplate1.airModel.vol.dynBal.m rectangularZoneTemplate1.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate1.airModel.vol.dynBal.U rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outCei.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outCei.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outCei.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outCei.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[3] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[4] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[5] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[6] rectangularZoneTemplate1.slaOnGro.layGro.monLay[1].monLayDyn.T[7] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[3] rectangularZoneTemplate1.slaOnGro.layGro.monLay[2].monLayDyn.T[4] rectangularZoneTemplate1.slaOnGro.layGro.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[3] rectangularZoneTemplate1.slaOnGro.layMul.monLay[1].monLayDyn.T[4] rectangularZoneTemplate1.slaOnGro.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.slaOnGro.layMul.monLay[4].monLayDyn.T[1] rectangularZoneTemplate1.winC.heaCapGlaExt.T rectangularZoneTemplate1.winC.heaCapGlaInt.T senTemSup.T tan.vol[1].dynBal.U tan.vol[2].dynBal.U val.val.actPos.y val1.val.actPos.y | EEl.y heaPum.con.vol.dynBal.U heaPum.eva.vol.dynBal.U pumpPrim.motSpe.y pumpPrim.vol.dynBal.U pumpSec.motSpe.y pumpSec.vol.dynBal.U rad.vol[1].dynBal.U rad.vol[2].dynBal.U rad.vol[3].dynBal.U rad.vol[4].dynBal.U rad.vol[5].dynBal.U rad1.vol[1].dynBal.U rad1.vol[2].dynBal.U rad1.vol[3].dynBal.U rad1.vol[4].dynBal.U rad1.vol[5].dynBal.U rectangularZoneTemplate.airModel.vol.dynBal.m rectangularZoneTemplate.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate.airModel.vol.dynBal.U rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.intC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.intC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.intFlo.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.intFlo.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.intFlo.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.intFlo.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.intFlo.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outA.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outA.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate.winA.heaCapGlaExt.T rectangularZoneTemplate.winA.heaCapGlaInt.T rectangularZoneTemplate1.airModel.vol.dynBal.m rectangularZoneTemplate1.airModel.vol.dynBal.medium.Xi[1] rectangularZoneTemplate1.airModel.vol.dynBal.U rectangularZoneTemplate1.intFlo.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.intFlo.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.intFlo.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.intFlo.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.intFlo.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outB.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outB.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outC.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outC.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[1].monLayDyn.T[2] rectangularZoneTemplate1.outD.layMul.monLay[2].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[1] rectangularZoneTemplate1.outD.layMul.monLay[3].monLayDyn.T[2] rectangularZoneTemplate1.winC.heaCapGlaExt.T rectangularZoneTemplate1.winC.heaCapGlaInt.T senTemSup.T tan.vol[1].dynBal.U tan.vol[2].dynBal.U val.val.actPos.y val1.val.actPos.y |
The figure below shows the change in reference variables:

In the Test results the TSensor is lower due to change in floor construction type.
Less on/off cycle of the heat pump occur due to the decoupling of production and emission system through the tank.
There was a problem hiding this comment.
Same considerations of DetailedHouse1 holds for the change in the reference results.
The figure below shows the change in reference variables:

In the Test results the TSensor is lower due to change in floor construction type.
Less on/off cycle of the heat pump and a more stable condenser temperature results from decoupling the production and emission system through the tank.
There was a problem hiding this comment.
There was a problem hiding this comment.
Same considerations of DetailedHouse9 holds for the change in the reference results.




Fixes #1389.
More detailed documentation and result visualization can be added if deemed valuable. This can be combined with open-ideas/__CrashCourse__#25. and #1374