Skip to content

Conversation

@jsquyres
Copy link
Member

Followup to commit 694e78a (i.e., PR #13381): Ben Menadue @benmenadue correctly pointed out that < should have been <=.

Refs #13375.

@bosilca
Copy link
Member

bosilca commented Aug 27, 2025

Have you tested it with the reproduced provided on the initial issue ?

Copy link
Member

@hppritcha hppritcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry didn't catch this last time!

@jsquyres
Copy link
Member Author

Have you tested it with the reproduced provided on the initial issue ?

Yes -- tried all 3 cases:

  1. Original c string is 0123456789abcdef (i.e., 16 characters + \0)
  2. The "f string" is actually 32 characters long, and is memset zeroed out before each of the 3 cases (so that I can opal_output the result)
  3. case 1: call ompi_fortran_string_c2f() with len=8.
  4. case 2: call ompi_fortran_string_c2f() with len=16.
  5. case 3: call ompi_fortran_string_c2f() with len=20.
[Little-Beezle.local:85670] JMS: cstr = 0123456789abcdef
[Little-Beezle.local:85670] JMS: strlen(cstr) = 16, len = 8
[Little-Beezle.local:85670] JMS: Called with fstr len=8, result: -->01234567<--
[Little-Beezle.local:85670] JMS: strlen(cstr) = 16, len = 16
[Little-Beezle.local:85670] JMS: Called with fstr len=16, result: -->0123456789abcdef<--
[Little-Beezle.local:85670] JMS: strlen(cstr) = 16, len = 20
[Little-Beezle.local:85670] JMS: Called with fstr len=20, result: -->0123456789abcdef    <--

Followup to commit 694e78a: Ben Menadue correctly pointed out that <
should have been <=.

Signed-off-by: Jeff Squyres <[email protected]>
@jsquyres jsquyres force-pushed the pr/fortran-c2-string-again branch from 9291f4e to cc03d5b Compare August 27, 2025 17:10
@jsquyres
Copy link
Member Author

Did a no-change-force-push in an attempt to clear the error with community / AWS CI (there was a disk space problem on the CI nodes that has now been fixed).

@jsquyres jsquyres merged commit 097f241 into open-mpi:main Aug 28, 2025
16 of 17 checks passed
@jsquyres jsquyres deleted the pr/fortran-c2-string-again branch August 28, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants