Skip to content

fortran: fix off-by-one string copy error #13387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

fortran: fix off-by-one string copy error #13387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ompi/mpi/fortran/base/strings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ int ompi_fortran_string_c2f(const char *cstr, char *fstr, int len)
// trailing \0 into the last position in fstr. This is not what
// Fortran wants; overwrite that \0 with the actual last character
// that will fit into fstr.
if (len < strlen(cstr)) {
if (len <= strlen(cstr)) {
fstr[len - 1] = cstr[len - 1];
} else {
// Otherwise, pad the end of the resulting Fortran string with
Expand Down
Loading