v4.0.x: regx/base: fix an integer overflow #6739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2019
Closed
|
@perrynzhou For future submissions, note that you can just update / change an existing PR without creating a new one (e.g., you can squash / edit commits on a single PR without closing an existing one and then opening a new one). It was a bit confusing that there were multiple PRs for this issue. The UH CI appears to be offline. Let's see if a new round of CI will fix the issue... bot:retest |
@jsquyres thanks for your suggest. |
use strtol() instead of atoi() in order to handle hostnames containing a large number. This is a one-off commit for the release branches since the regx framework has already been removed from master. Refs. open-mpi#6729 Signed-off-by: perrynzhou <[email protected]>
ggouaillardet
force-pushed
the
topic/regx_atoi
branch
from
a7c82ed to
5acaf00
Compare
|
@jsquyres I just fixed the metadata of the commit |
|
bot:ompi:retest |
|
@ggouaillardet Many thanks. |
jsquyres
approved these changes
Jun 6, 2019
jsquyres
changed the title
rhc54
approved these changes
Jun 7, 2019
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Jun 7, 2019
Backport of open-mpi/ompi#6739 Signed-off-by: Ralph Castain <[email protected]>
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Jun 25, 2019
Backport of open-mpi/ompi#6739 Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit fc4875c)
rhc54
added a commit
to rhc54/openpmix
that referenced
this pull request
Jun 26, 2019
Backport of open-mpi/ompi#6739 Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit fc4875c)
karasevb
pushed a commit
to karasevb/pmix
that referenced
this pull request
Aug 19, 2019
Backport of open-mpi/ompi#6739 Signed-off-by: Ralph Castain <[email protected]> (cherry picked from commit fc4875c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use strtol() instead of atoi() in order to handle hostnames
containing a large number.
Thanks perrynzhou for the report and fix.
This is a one-off commit for the release branches since
the regx framework has already been removed from master.
Refs. #6729
Signed-off-by: Gilles Gouaillardet [email protected]