Publish WaitForCharge phase completed #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiyu Oh <[email protected]>
1 task
mxgrey
reviewed
Jan 24, 2026
| { | ||
| StatusMsg msg; | ||
| msg.state = msg.STATE_COMPLETED; | ||
| msg.status = "Completed phase [" + active->_description + "]"; |
Contributor
There was a problem hiding this comment.
Small nitpick but this is meant to be brief message that indicates the status of this phase specifically. I think it's a bit excessive to print out the entire phase description. When a user sees this status message, it will already be nestled inside the context of this phase.
A simpler message such as Reached intended battery charge would probably serve better. As it stands, this message would end up looking something like
Completed phase [Charging [TinyRobot/TinyRobot_1] to [90%]]
Member
Author
Signed-off-by: Xiyu Oh <[email protected]>
Signed-off-by: Xiyu Oh <[email protected]>
Signed-off-by: Xiyu Oh <[email protected]>
mxgrey
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets open-rmf/rmf_demos#343
Currently when a robot is assigned a Charge task (as finishing request or as emergency charging when its battery SOC falls below a threshold), the task would begin and ends only when
When the Charge task ends, its Status remains in
Standbyinstead of being marked asCompleted. While this does not affect the robot's behavior (it can still proceed to execute subsequent tasks), the task status is reflected on the web dashboard and can be misleading. Over time the dashboard's Tasks tab can look like this, with the Charge tasks unresolved:(Charge tasks are those dated 1 Jan 1970)
This PR publishes a final StatusMsg to mark WaitForCharge with
STATE_COMPLETEDbefore moving onto the next phase.