Support aligning lanes to x or y axis during creation#402
Support aligning lanes to x or y axis during creation#402
Conversation
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
|
Similar to my feedback on multi-select I don't think we should monitor One simple approach that would at least be somewhat better is to have a We should also give |
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
|
I tried this on a "low FPS" machine and noticed that there is a one frame delay between the lane update and the snapping feature, which makes the lane a bit wobbly and not clearly snapping to one axis when dragging, as shown below: Screencast.From.2025-10-24.10-14-06.mp4On a more personal opinion that can be argued against I wonder if it would make sense to change the transform of the |
Signed-off-by: Xiyu Oh <xiyu@openrobotics.org>
|
@luca-della-vedova your intuition was right, setting the transform of the cursor frame directly helps with the latency! |
|
Closing in favor of #420 |
Targets one of the QOL items in #337.
This PR adds support for lane alignment - when creating lanes, pressing
ShiftLeftwould "lock" the end anchor transform such that the created lane would be aligned to the X- or Y- axis, depending on the cursor displacement from the start anchor. Releasing the button "unlocks" the alignment.Hovering over an existing anchor also "unlocks" the lane alignment, so users can still select existing anchors even if the
ShiftLeftbutton is pressed.Changes also include updating the
create_edgesworkflow to pass around a newButtonInputTypestruct fromKeyboardServices. This allows us to differentiate betweenpressed,just_pressedandjust_releasedbutton interactions from within the workflow.