Skip to content

Conversation

@davidhjp01
Copy link
Contributor

Additional APIs for connecting string/boolean variables

@davidhjp01 davidhjp01 requested a review from restenb May 5, 2025 18:28
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cosim_value_reference outputValueReference,
cosim_slave_index inputSlaveIndex,
cosim_value_reference inputValueReference);
/// Creates an observer which stores the last observed value for all variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some whitespace missing here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh, just noticed after merging.

@davidhjp01 davidhjp01 merged commit ab073bd into master May 6, 2025
16 checks passed
@davidhjp01 davidhjp01 deleted the string_boolean_connect_variables branch May 6, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants