fix(ottl): enforce valid types for setters in contexts #43505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
changed the title
jsvd
force-pushed
the
fix_40198_simple
branch
from
cb432ea to
34947d7
Compare
jsvd
changed the title
jsvd
requested review from
a team,
TylerHelmuth,
edmocosta and
evan-bradley
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a common utility to check for the expected type and returns a consistent error message.
Also applies the use of this utility to ctxscope, ctxlog and ctxmetric.
Link to tracking issue
Fixes #40198
Testing
Adds testing for the new utility, will address any tests whose behavior is changed by this propagation of error that didn't exist before.
TODO
As it is now, the PR changes some but not all setters, I can either apply them all here or create a followup PR with more refactorings.
Alternate designs
Introducing a new helper in ctxerror was considered but it can be done at a later stage, as it requires consensus on the set of metadata that such helper would require or optional (e.g. context name, path segment).