Skip to content

[exporterhelper] Enable block_on_overflow by default #13847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[exporterhelper] Enable block_on_overflow by default #13847

wants to merge 1 commit into from

Conversation

@mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 16, 2025

Description

This is a test to see how our test suite behaves with block_on_overflow set to true

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 1, 2025
jmacd
jmacd approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the better default behavior!

I would expect a feature-flag for this change, but definitely approve the transition.

lahsivjar
lahsivjar approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on block_on_overflow: true being a better default.

@lahsivjar lahsivjar mentioned this pull request Oct 3, 2025
Merged
@github-actions github-actions bot removed the Stale label Oct 8, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmacd jmacd jmacd approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu will be requested when the pull request is marked ready for review bogdandrutu is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax will be requested when the pull request is marked ready for review dmitryax is a code owner

+1 more reviewer

@lahsivjar lahsivjar lahsivjar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mx-psi @lahsivjar @jmacd