Skip to content

[exporterhelper] Enable block_on_overflow by default #13847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[exporterhelper] Enable block_on_overflow by default #13847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exporter/exporterhelper/internal/queue_sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
)

// NewDefaultQueueConfig returns the default config for queuebatch.Config.
// By default, the queue stores 1000 requests of telemetry and is non-blocking when full.
// By default, the queue stores 1000 requests of telemetry and is blocking when full.
func NewDefaultQueueConfig() queuebatch.Config {
return queuebatch.Config{
Enabled: true,
Expand All @@ -24,7 +24,7 @@ func NewDefaultQueueConfig() queuebatch.Config {
// This can be estimated at 1-4 GB worth of maximum memory usage
// This default is probably still too high, and may be adjusted further down in a future release
QueueSize: 1_000,
BlockOnOverflow: false,
BlockOnOverflow: true,
}
}

Expand Down
Loading