Fix observable updown counter aggregation temporality in Geneva exporter #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observable updown counters were incorrectly exporting delta values instead of cumulative values to Geneva. This happened because the
GetAggregationTemporalitymethod in the Geneva exporter only checked forkUpDownCounterinstrument types but missedkObservableUpDownCountertypes.Both regular and observable updown counters should use cumulative aggregation temporality for proper Geneva export behavior, as updown counters represent values that can go up and down and need to maintain their absolute state rather than just reporting changes.
Changes
Updated the conditional check in
GetAggregationTemporalityto include both instrument types:Added comprehensive unit test
GetAggregationTemporalityTestthat verifies:kUpDownCounterreturnskCumulative(existing behavior)kObservableUpDownCounterreturnskCumulative(fixed behavior)kCounterandkHistogramcontinue to returnkDeltaThis minimal change ensures observable updown counters export their cumulative values to Geneva correctly, matching the behavior of regular updown counters.
Fixes #570.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.