Skip to content

Fix observable updown counter aggregation temporality in Geneva exporter #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

Fix observable updown counter aggregation temporality in Geneva exporter #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
531c222
Initial plan
Copilot Sep 17, 2025
0c3bb4b
Initial analysis: identified Observable UpDown Counter aggregation te…
Copilot Sep 17, 2025
b6f35bc
Fix observable updown counter aggregation temporality in Geneva exporter
Copilot Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exporters/geneva/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
build/
8 changes: 4 additions & 4 deletions exporters/geneva/src/exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ Exporter::Exporter(const ExporterOptions &options)

sdk::metrics::AggregationTemporality Exporter::GetAggregationTemporality(
sdk::metrics::InstrumentType instrument_type) const noexcept {
if (instrument_type == sdk::metrics::InstrumentType::kUpDownCounter)
{
return sdk::metrics::AggregationTemporality::kCumulative;
}
if (instrument_type == sdk::metrics::InstrumentType::kUpDownCounter ||
instrument_type == sdk::metrics::InstrumentType::kObservableUpDownCounter) {
return sdk::metrics::AggregationTemporality::kCumulative;
}
return sdk::metrics::AggregationTemporality::kDelta;
}

Expand Down
20 changes: 20 additions & 0 deletions exporters/geneva/test/metrics_exporter_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,4 +379,24 @@ INSTANTIATE_TEST_SUITE_P(GenericMetricsExporterText,
GenericMetricsExporterTextFixture,
::testing::Values(kUnixDomainPathUDS, kUnixDomainPathAbstractSocket));

// Test for GetAggregationTemporality method
TEST(GenevaExporterTest, GetAggregationTemporalityTest) {
ExporterOptions options{"Endpoint=unix:///tmp/test;Account=test;Namespace=test"};
Exporter exporter(options);

// Test that kUpDownCounter returns kCumulative
EXPECT_EQ(exporter.GetAggregationTemporality(InstrumentType::kUpDownCounter),
AggregationTemporality::kCumulative);

// Test that kObservableUpDownCounter returns kCumulative
EXPECT_EQ(exporter.GetAggregationTemporality(InstrumentType::kObservableUpDownCounter),
AggregationTemporality::kCumulative);

// Test that other instrument types return kDelta
EXPECT_EQ(exporter.GetAggregationTemporality(InstrumentType::kCounter),
AggregationTemporality::kDelta);
EXPECT_EQ(exporter.GetAggregationTemporality(InstrumentType::kHistogram),
AggregationTemporality::kDelta);
}

#endif